gh-135755: Move SPECIAL_ constants to a private header - #135922
Merged
encukou merged 1 commit intoJun 25, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Macros without a `Py`/`_Py` prefix should not be defined in public headers.
39 tasks
iritkatriel
approved these changes
Jun 25, 2025
Copy link
Copy Markdown
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker 1b1ae82fab0093924b8b89eb1c7eea11d7be7b18 3.14 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-135926 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Jun 25, 2025
…ythonGH-135922) Macros without a `Py`/`_Py` prefix should not be defined in public headers. (cherry picked from commit 1b1ae82) Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
added a commit
that referenced
this pull request
Jun 25, 2025
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…H-135922) Macros without a `Py`/`_Py` prefix should not be defined in public headers.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…H-135922) Macros without a `Py`/`_Py` prefix should not be defined in public headers.
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…H-135922) Macros without a `Py`/`_Py` prefix should not be defined in public headers.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…H-135922) Macros without a `Py`/`_Py` prefix should not be defined in public headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macros without a Py/_Py prefix should not be defined in public headers.
These were added in #120640.