FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-120713: Make _Py_NORMALIZE_CENTURY private by encukou · Pull Request #135933 · python/cpython · GitHub

/ cpython Public

gh-120713: Make _Py_NORMALIZE_CENTURY private - #135933

Merged
encukou merged 7 commits into
python:mainfrom
encukou:private-Py_NORMALIZE_CENTURY
Jul 7, 2025
ConversationCommits (7)ChecksFiles changed
Merged

gh-120713: Make _Py_NORMALIZE_CENTURY private#135933
encukou merged 7 commits into
python:mainfrom
encukou:private-Py_NORMALIZE_CENTURY

Conversation

encukou commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Users don't need this macro, and we don't want to document & support it. Right?

(We're not very consistent with configure macros, but we can start making things better with ones added in 3.14.)

bedevere-app Bot mentioned this pull request Jun 25, 2025
Closed
encukou mentioned this pull request Jun 26, 2025
Closed
39 tasks

serhiy-storchaka commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

See also other approach in #128444 which allows to get rid of that macro.

encukou added the needs backport to 3.14 bugs and security fixes label Jun 26, 2025

encukou commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Do you intend to backport #128444 to 3.14?

serhiy-storchaka commented Jun 26, 2025

Copy link
Copy Markdown
Member

If it is reviewed and accepted. I do not risk to merge it without review.

encukou commented Jul 7, 2025

Copy link
Copy Markdown
Member Author

I'll merge this, and update the other PR(s) to remove the private macro.

encukou merged commit fb170cf into python:main Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

encukou deleted the private-Py_NORMALIZE_CENTURY branch July 7, 2025 15:57
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
06720fd 
(cherry picked from commit fb170cf)

Co-authored-by: Petr Viktorin <encukou@gmail.com>

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136387 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 8, 2025
[3.14] gh-120713: Make _Py_NORMALIZE_CENTURY private (GH-135933) (#13…
376e037 
…6387)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
8f7d86d
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
dc6ed76
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
0d1a69a
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
1ea68b8
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
79668d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pganssle Awaiting requested review from pganssle pganssle is a code owner
abalkin Awaiting requested review from abalkin
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL