FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135755: Document the new `PyFunction_GET_BUILTINS` macro by ZeroIntensity · Pull Request #135934 · python/cpython · GitHub

/ cpython Public

gh-135755: Document the new PyFunction_GET_BUILTINS macro - #135934

Closed
ZeroIntensity wants to merge 2 commits into
python:mainfrom
ZeroIntensity:document-get-builtins
ConversationCommits (2)ChecksFiles changed
Closed

gh-135755: Document the new PyFunction_GET_BUILTINS macro#135934
ZeroIntensity wants to merge 2 commits into
python:mainfrom
ZeroIntensity:document-get-builtins

Conversation

ZeroIntensity commented Jun 25, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

ZeroIntensity requested a review from encukou June 25, 2025 13:04
ZeroIntensity added docs Documentation in the Doc dir skip news topic-C-API needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
github-project-automation Bot moved this to Todo in Docs PRs Jun 25, 2025
bedevere-app Bot mentioned this pull request Jun 25, 2025
Closed
39 tasks
encukou reviewed Jun 25, 2025
View reviewed changes
Comment thread Doc/c-api/function.rst
Comment on lines +150 to +152
This function cannot fail and does not do error checking; passing anything
other than an instance of :c:data:`PyFunction_Type` is undefined behavior.
There is no ``PyFunction_Get*`` equivalent for this function.

encukou Jun 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hm, I don't think C API WG would approve.
Should this function be in a private header (and with an underscore) instead? It looks untested as well.

ZeroIntensity Jun 25, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's sort of tested. I'm not opposed to making it private.

encukou Jun 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

That looks like it's used in a test -- the test assumes that it's working?
Yeah, the more I look into it, the better making it private seems.

cc @ericsnowcurrently, who added PyFunction_GET_BUILTINS in #133128

ZeroIntensity Jun 25, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll put up an alternate PR.

ericsnowcurrently Jun 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

FWIW, I agree with making it internal-only.

ZeroIntensity mentioned this pull request Jun 25, 2025
Merged

encukou commented Jun 26, 2025

Copy link
Copy Markdown
Member

Superseded by #135938

encukou closed this Jun 26, 2025
ZeroIntensity deleted the document-get-builtins branch June 26, 2025 11:30
AA-Turner removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments
ericsnowcurrently ericsnowcurrently left review comments

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news topic-C-API

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL