FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 by moreal · Pull Request #136027 · python/cpython · GitHub

/ cpython Public

gh-108765: fix comment about macro definitions in _stat.c post GH-108854 - #136027

Merged
picnixz merged 1 commit into
python:mainfrom
moreal:fix-staled-comments
Jun 27, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-108765: fix comment about macro definitions in _stat.c post GH-108854#136027
picnixz merged 1 commit into
python:mainfrom
moreal:fix-staled-comments

Conversation

moreal commented Jun 27, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This pull request only fixes a typo in the _stat.c file.

Since #108854, the definitions of S_ISDIR(), S_ISREG() and S_ISCHR(), as well as the part that includes sys/stat.h, have moved from Include/pyport.h to Include/fileutils.h. However the comment in Modules/_stat.c still refers to Include/pyport.h so this pull request fixes it.

As note, I didn't create and add an issue number because I think it is a trivial change. In the same context, I didn't think it was necessary to add NEWS as well.

python-cla-bot Bot commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

This comment was marked as resolved.

Sign in to view
moreal changed the title Fix staled comments in _stat.c Update a comment in _stat.c to latest Jun 27, 2025
moreal force-pushed the fix-staled-comments branch from f0cfe18 to 1fe7601 Compare June 27, 2025 10:44

This comment was marked as resolved.

Sign in to view
moreal force-pushed the fix-staled-comments branch from 1fe7601 to 88aeb4b Compare June 27, 2025 14:49
picnixz changed the title Update a comment in _stat.c to latest gh-108765: fix comment about macro definitions in _stat.c Jun 27, 2025
bedevere-app Bot mentioned this pull request Jun 27, 2025
Closed
picnixz changed the title gh-108765: fix comment about macro definitions in _stat.c gh-108765: fix comment about macro definitions in _stat.c post GH-108854 Jun 27, 2025

picnixz commented Jun 27, 2025

Copy link
Copy Markdown
Member

@StanFromIreland In general, if the PR amends a previous PR, we can reuse the issue number of that PR (if there is one).

picnixz enabled auto-merge (squash) June 27, 2025 14:53
picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 27, 2025

StanFromIreland commented Jun 27, 2025

Copy link
Copy Markdown
Member

I was considering that, I hesitated for a few minutes before applying the label...

My reasoning was, the issue was quite broad and would not add much, but I guess it is good to do so anyway. I will do so in the future!

picnixz commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

For such PRs I usually add "post GH-*" in the title so that one can click on it as well.

picnixz merged commit 0141e7f into python:main Jun 27, 2025

miss-islington-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

Thanks @moreal for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
94ead81 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136043 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
73da079 
…pythonGH-108854 (pythonGH-136027)

(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136044 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 27, 2025
picnixz pushed a commit that referenced this pull request Jun 27, 2025
[3.13] gh-108765: fix comment about macro definitions in _stat.c post
ad1b0c9 
GH-108854 (GH-136027) (#136044)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
picnixz pushed a commit that referenced this pull request Jun 27, 2025
[3.14] gh-108765: fix comment about macro definitions in _stat.c post
eff347c 
GH-108854 (GH-136027) (#136043)

gh-108765: fix comment about macro definitions in `_stat.c` post GH-108854 (GH-136027)
(cherry picked from commit 0141e7f)

Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
ZeroIntensity mentioned this pull request Jun 27, 2025
Merged
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
dd67d75 
…pythonGH-108854 (python#136027)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
afc689a 
…pythonGH-108854 (python#136027)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
9ff805e 
…pythonGH-108854 (python#136027)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-108765: fix comment about macro definitions in _stat.c post …
7243f39 
…pythonGH-108854 (python#136027)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL