FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136063: fix quadratic-complexity parsing in `email.message._parseparam` by picnixz · Pull Request #136072 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136063: fix quadratic-complexity parsing in email.message._parseparam - #136072

Merged
ambv merged 4 commits into
python:mainfrom
picnixz:fix/email/parseparam-dos-136063
Oct 31, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-136063: fix quadratic-complexity parsing in email.message._parseparam#136072
ambv merged 4 commits into
python:mainfrom
picnixz:fix/email/parseparam-dos-136063

Conversation

picnixz commented Jun 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka I think this one can be done without changing the interface. Just to be sure, but count() and find() have all linear complexities right (linear in the window they are using, not in the entire string).

bedevere-app Bot mentioned this pull request Jun 28, 2025
Open
picnixz force-pushed the fix/email/parseparam-dos-136063 branch from 8763366 to d356a14 Compare June 28, 2025 12:44
picnixz requested a review from serhiy-storchaka June 28, 2025 12:49
picnixz marked this pull request as ready for review June 28, 2025 12:49
picnixz requested a review from a team as a code owner June 28, 2025 12:49
picnixz added the type-security A security issue label Jun 29, 2025
aeurielesn reviewed Jul 19, 2025
View reviewed changes
Comment thread Lib/email/message.py Outdated
picnixz marked this pull request as draft July 20, 2025 07:54
picnixz marked this pull request as ready for review July 20, 2025 09:09
picnixz added needs backport to 3.9 needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 20, 2025

picnixz commented Jul 29, 2025

Copy link
Copy Markdown
Member Author

@serhiy-storchaka friendly ping

ambv merged commit 680a5d0 into python:main Oct 31, 2025
45 checks passed

miss-islington-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks @picnixz for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
7a8ebb2 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
67e8c17 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140827 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 31, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
f8f3e70 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140828 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 31, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
134369a 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140829 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
3d1bc22 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 31, 2025

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140830 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label Oct 31, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
bbebf3b 
…parseparam` (pythonGH-136072)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140831 is a backport of this pull request to the 3.10 branch.

bedevere-app Bot commented Oct 31, 2025

Copy link
Copy Markdown

GH-140832 is a backport of this pull request to the 3.9 branch.

ambv pushed a commit that referenced this pull request Oct 31, 2025
[3.9] gh-136063: fix quadratic-complexity parsing in `email.message._…
90719e3 
…parseparam` (GH-136072) (GH-140832)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
ambv added a commit that referenced this pull request Oct 31, 2025
[3.11] gh-136063: fix quadratic-complexity parsing in `email.message.…
3b7d81d 
…_parseparam` (GH-136072) (GH-140830)

(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
picnixz deleted the fix/email/parseparam-dos-136063 branch November 2, 2025 09:33
hugovk pushed a commit that referenced this pull request Nov 30, 2025
[3.14] gh-136063: fix quadratic-complexity parsing in `email.message.…
848a2eb 
…_parseparam` (GH-136072) (#140827)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Nov 30, 2025
[3.13] gh-136063: fix quadratic-complexity parsing in `email.message.…
b34ecec 
…_parseparam` (GH-136072) (#140828)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-136063: fix quadratic-complexity parsing in `email.message._…
aa928a9 
…parseparam` (pythonGH-136072)
Yhg1s pushed a commit that referenced this pull request Dec 22, 2025
[3.12] gh-136063: fix quadratic-complexity parsing in `email.message.…
1c00d7b 
…_parseparam` (GH-136072) (#140829)

gh-136063: fix quadratic-complexity parsing in `email.message._parseparam` (GH-136072)
(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Jan 25, 2026
[3.10] gh-136063: fix quadratic-complexity parsing in `email.message.…
6027dbb 
…_parseparam` (GH-136072) (#140831)

gh-136063: fix quadratic-complexity parsing in `email.message._parseparam` (GH-136072)
(cherry picked from commit 680a5d0)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz mentioned this pull request Apr 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka Awaiting requested review from serhiy-storchaka
1 more reviewer
aeurielesn aeurielesn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL