FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-127604: Docs: Include a C stack in the `faulthandler` example by ZeroIntensity · Pull Request #136081 · python/cpython · GitHub

/ cpython Public

gh-127604: Docs: Include a C stack in the faulthandler example - #136081

Merged
ZeroIntensity merged 2 commits into
python:mainfrom
ZeroIntensity:faulthandler-c-stack-docs
Jun 29, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-127604: Docs: Include a C stack in the faulthandler example#136081
ZeroIntensity merged 2 commits into
python:mainfrom
ZeroIntensity:faulthandler-c-stack-docs

Conversation

ZeroIntensity commented Jun 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

ZeroIntensity added docs Documentation in the Doc dir skip news needs backport to 3.14 bugs and security fixes labels Jun 28, 2025
github-project-automation Bot moved this to Todo in Docs PRs Jun 28, 2025
ZeroIntensity changed the title gh-127604: Include a C stack in the faulthandler example gh-127604: Docs: Include a C stack in the faulthandler example Jun 28, 2025
bedevere-app Bot mentioned this pull request Jun 28, 2025
Closed

ZeroIntensity commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

@picnixz Are you around to do a quick review?

picnixz commented Jun 29, 2025

Copy link
Copy Markdown
Member

I'm around for 3h max and then I'm off for 10 days.

picnixz reviewed Jun 29, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Let's omit some lines even if it won't be omitted. If we change how string_at behaves or if the way calls are performed change, then it will need us to rewrite this example. Instead, I suggest to have some ... after _Py_DumpStack

ZeroIntensity commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

I think it's ok to keep the addresses there for completeness, it's there as an example, not necessarily as a precise depiction of what happens if you call string_at(0). I was more worried about the line length or something like that.

picnixz commented Jun 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

May I suggest replacing /home/python/cpython/build/lib.linux-x86_64-3.15/_ctypes.cpython-315d-x86_64-linux-gnu.so by a home that is smaller, e.g., /opt/python/lib.linux-... ?

picnixz reviewed Jun 29, 2025
View reviewed changes
Comment thread Doc/library/faulthandler.rst
picnixz approved these changes Jun 29, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I trust you about the different line numbers (hopefully it's coming from a real example).

ZeroIntensity commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

Yeah, I just copy-pasted the output from a local run of ctypes.string_at(0).

ZeroIntensity merged commit 3947847 into python:main Jun 29, 2025

miss-islington-app Bot commented Jun 29, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 29, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
735f775 
pythonGH-136081)

(cherry picked from commit 3947847)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app Bot commented Jun 29, 2025

Copy link
Copy Markdown

GH-136102 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 29, 2025
ZeroIntensity deleted the faulthandler-c-stack-docs branch June 29, 2025 14:58
ZeroIntensity added a commit that referenced this pull request Jun 29, 2025
[3.14] gh-127604: Docs: Include a C stack in the faulthandler examp…
231d801 
…le (GH-136081) (GH-136102)

* gh-127604: Docs: Include a C stack in the `faulthandler` example (GH-136081)
(cherry picked from commit 3947847)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
c74b91b 
pythonGH-136081)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
7fde5da 
pythonGH-136081)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
9d489ee 
pythonGH-136081)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
47cddbe 
pythonGH-136081)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-127604: Docs: Include a C stack in the faulthandler example (
ae6401b 
pythonGH-136081)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL