FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-90733: improve `hashlib.scrypt` interface by picnixz · Pull Request #136100 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-90733: improve hashlib.scrypt interface - #136100

Merged
picnixz merged 3 commits into
python:mainfrom
picnixz:fix/hashlib/openssl-scrypt-90733
Jul 14, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-90733: improve hashlib.scrypt interface#136100
picnixz merged 3 commits into
python:mainfrom
picnixz:fix/hashlib/openssl-scrypt-90733

Conversation

picnixz commented Jun 29, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  1. scrypt is now unconditionally available so there's no need for this additional define
  2. we actually never exposed scrypt in __all__ so I exposed it
  3. the limits for maxmem and dklen are too restrictive in its current form, but it's also fine in some sense as allowing for a larger maxmem also means removing protections and allowing for VERY large dklen isn't necessary.

picnixz requested review from gpshead and tiran as code owners June 29, 2025 13:38
bedevere-app Bot mentioned this pull request Jun 29, 2025
Closed
picnixz force-pushed the fix/hashlib/openssl-scrypt-90733 branch from 9f92510 to eb1565c Compare June 29, 2025 14:08
picnixz force-pushed the fix/hashlib/openssl-scrypt-90733 branch from eb1565c to 0adf063 Compare June 29, 2025 14:30

picnixz commented Jun 29, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Jun 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 0adf063 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136100%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz marked this pull request as draft July 13, 2025 11:38

python-cla-bot Bot commented Jul 13, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

picnixz commented Jul 13, 2025

Copy link
Copy Markdown
Member Author

HA. I merged in the wrong order!

picnixz force-pushed the fix/hashlib/openssl-scrypt-90733 branch from 1503249 to 0adf063 Compare July 13, 2025 11:43
picnixz marked this pull request as ready for review July 13, 2025 11:44

picnixz commented Jul 14, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Jul 14, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 41646c4 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136100%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz merged commit a68ddea into python:main Jul 14, 2025
picnixz deleted the fix/hashlib/openssl-scrypt-90733 branch July 14, 2025 10:49
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-90733: improve hashlib.scrypt interface (python#136100)
80b31c1 
* add `scrypt` to `hashlib.__all__`
* improve `hashlib.scrypt` exception messages
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-90733: improve hashlib.scrypt interface (python#136100)
15aa1a9 
* add `scrypt` to `hashlib.__all__`
* improve `hashlib.scrypt` exception messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead Awaiting requested review from gpshead gpshead is a code owner
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL