FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix sphinx warnings in `whatsnew/3.9` by sobolevn · Pull Request #136163 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix sphinx warnings in whatsnew/3.9 - #136163

Merged
hugovk merged 2 commits into
python:mainfrom
sobolevn:issue-101100-3.9
Jul 7, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-101100: Fix sphinx warnings in whatsnew/3.9#136163
hugovk merged 2 commits into
python:mainfrom
sobolevn:issue-101100-3.9

Conversation

sobolevn commented Jul 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

It used to be:

/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_GETLK [ref.const]
/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_SETLK [ref.const]
/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_SETLKW [ref.const]
/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:647: WARNING: py:attr reference target not found: random.Random.randbytes [ref.attr]
/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:779: WARNING: py:func reference target not found: set.difference_update [ref.func]
/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:1141: WARNING: py:func reference target not found: encodings.normalize_encoding [ref.func]

I opened #136162 about the encodings part.

I had to use

:meth:`!set.difference_update`

because stdtypes defines this method as frozenset.difference_update

📚 Documentation preview 📚: https://cpython-previews--136163.org.readthedocs.build/

sobolevn requested review from AA-Turner and hugovk as code owners July 1, 2025 08:00
bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Jul 1, 2025
github-project-automation Bot moved this to Todo in Docs PRs Jul 1, 2025
bedevere-app Bot mentioned this pull request Jul 1, 2025
Closed
sobolevn requested a review from rhettinger as a code owner July 1, 2025 09:43
sobolevn force-pushed the issue-101100-3.9 branch from 8fafbbf to 3054ebd Compare July 1, 2025 10:25
rhettinger removed their request for review July 4, 2025 00:59
hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
hugovk merged commit 0a33221 into python:main Jul 7, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (pythonGH-136163)
c6607ac 
(cherry picked from commit 0a33221)

Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (pythonGH-136163)
33cdbf3 
(cherry picked from commit 0a33221)

Co-authored-by: sobolevn <mail@sobolevn.me>

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136372 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136373 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
[3.13] gh-101100: Fix sphinx warnings in whatsnew/3.9 (GH-136163) (#…
d7bb308 
…136373)

Co-authored-by: sobolevn <mail@sobolevn.me>
hugovk pushed a commit that referenced this pull request Jul 7, 2025
[3.14] gh-101100: Fix sphinx warnings in whatsnew/3.9 (GH-136163) (#…
f02be2d 
…136372)

Co-authored-by: sobolevn <mail@sobolevn.me>
StanFromIreland reviewed Jul 7, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.9.rst

* :func:`codecs.lookup` now normalizes the encoding name the same way as
:func:`encodings.normalize_encoding`, except that :func:`codecs.lookup` also
:func:`!encodings.normalize_encoding`, except that :func:`codecs.lookup` also

StanFromIreland Jul 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This will be unnecessary with #136164, should I revert this there?

hugovk Jul 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes please :)

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (python#136163)
edc395a
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (python#136163)
4092fb5
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (python#136163)
391eb59
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (python#136163)
7842cfd
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-101100: Fix sphinx warnings in whatsnew/3.9 (python#136163)
c19a139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland left review comments
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL