FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-101100: Fix references in http.cookiejar docs #114658 by LamentXU123 · Pull Request #136238 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-101100: Fix references in http.cookiejar docs #114658 - #136238

Merged
ZeroIntensity merged 2 commits into
python:mainfrom
LamentXU123:fix-words-interrupt-in-doc-strict_ns_domain
Jul 5, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-101100: Fix references in http.cookiejar docs #114658#136238
ZeroIntensity merged 2 commits into
python:mainfrom
LamentXU123:fix-words-interrupt-in-doc-strict_ns_domain

Conversation

LamentXU123 commented Jul 3, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The origial doc is:

Since there is no highlights or any reference, I see no reason to split the doc of strict_ns_domain. I think maybe we can make the description of the acceptable value just below strict_ns_domain? The two addtributes within are likely to be added in the wrong place.

Another thing is the referrence link of strict_ns_domain is invalid in the original doc, since it's been interrupted and can't locate the attribute. (The .rst file is here)

This PR change it to:

Skipping issues and news ;)

📚 Documentation preview 📚: https://cpython-previews--136238.org.readthedocs.build/

bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 3, 2025
github-project-automation Bot moved this to Todo in Docs PRs Jul 3, 2025
ZeroIntensity requested a review from picnixz July 4, 2025 01:26
picnixz requested changes Jul 4, 2025
View reviewed changes

picnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please keep it as is. The attributes documented after this "weird" paragraph are the flags. This paragraph serves as a separation between regulat attributes and class variable constants that behave like flags.

In the future, please first create an issue to discuss such changes before or carefully check that there is something to change.

Note: the backlink is an issue that can be solved by this PR but don't move around the docs. Just add the DefaultCookiePolicy namespace and the ~ to suppress the fully qualified name.

bedevere-app Bot commented Jul 4, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

picnixz commented Jul 4, 2025

Copy link
Copy Markdown
Member

Use the issue that aims to remove warnings in the docs for this one.

LamentXU123 changed the title Doc: Fix interrupting words in doc ofDefaultCookiePolicy.strict_ns_domain gh-101100: Fix references in http.cookiejar docs #114658 Jul 5, 2025
bedevere-app Bot mentioned this pull request Jul 5, 2025
Closed

LamentXU123 commented Jul 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Done. Thank you for your review.

LamentXU123 commented Jul 5, 2025

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

bedevere-app Bot requested a review from picnixz July 5, 2025 03:50

picnixz commented Jul 5, 2025

Copy link
Copy Markdown
Member

@ZeroIntensity Can you remove my old review and merge this one? TiA

ZeroIntensity approved these changes Jul 5, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Silly bot

ZeroIntensity merged commit f0c7344 into python:main Jul 5, 2025
github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 5, 2025

miss-islington-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

Thanks @LamentXU123 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

Thanks @LamentXU123 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
95eb971 
…6238)

(cherry picked from commit f0c7344)

Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
b553c8a 
…6238)

(cherry picked from commit f0c7344)

Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

GH-136317 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 5, 2025

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

GH-136318 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
ZeroIntensity pushed a commit that referenced this pull request Jul 5, 2025
[3.14] gh-101100: Fix references in http.cookiejar docs (GH-136238) (…
53584d3 
…GH-136318)

gh-101100: Fix references in `http.cookiejar` docs (GH-136238)
(cherry picked from commit f0c7344)

Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull request Jul 5, 2025
[3.13] gh-101100: Fix references in http.cookiejar docs (GH-136238) (…
e7a2d2a 
…GH-136317)

gh-101100: Fix references in `http.cookiejar` docs (GH-136238)
(cherry picked from commit f0c7344)

Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
f54a660 
…6238)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
21c9c92 
…6238)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
e9e06a2 
…6238)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
a8418b3 
…6238)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-101100: Fix references in http.cookiejar docs (pythonGH-13…
57f7af2 
…6238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz approved these changes
ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL