FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133644: Remove `PySys_SetArgv*` for 3.15 by xuantengh · Pull Request #136277 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-133644: Remove PySys_SetArgv* for 3.15 - #136277

Open
xuantengh wants to merge 4 commits into
python:mainfrom
xuantengh:deprecate-pysys_set
ConversationCommits (4)ChecksFiles changed
Open

gh-133644: Remove PySys_SetArgv* for 3.15#136277
xuantengh wants to merge 4 commits into
python:mainfrom
xuantengh:deprecate-pysys_set

Conversation

xuantengh commented Jul 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Remove PySys_SetArgv and PySys_SetArgvEx.

📚 Documentation preview 📚: https://cpython-previews--136277.org.readthedocs.build/

xuantengh requested review from a team, encukou and ericsnowcurrently as code owners July 4, 2025 07:47
xuantengh changed the title Remove PySys_SetArgv* for 3.15 gh-133644: Remove PySys_SetArgv* for 3.15 Jul 4, 2025
bedevere-app Bot mentioned this pull request Jul 4, 2025
Open
6 of 9 tasks
ZeroIntensity reviewed Jul 4, 2025
View reviewed changes
Comment thread Misc/stable_abi.toml
Comment on lines -1338 to -1341
[function.PySys_SetArgv]
added = '3.2'
[function.PySys_SetArgvEx]
added = '3.2'

ZeroIntensity Jul 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We shouldn't remove the entry here, we should just mark them as abi_only = true.

zooba Jul 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Which will preserve them in python3dll.c, which is the actual breaking change (or at least the one that can be easily seen in a source diff).

Arguably they should stay in the header files as well, possibly only when Py_LIMITED_API is set. The functionality can change if it needs to, though ideally wouldn't break every existing user.

Comment thread Misc/NEWS.d/next/C_API/2025-07-04-15-44-49.gh-issue-133644.Oao-7A.rst Outdated

picnixz commented Jul 4, 2025

Copy link
Copy Markdown
Member

Please check if there are projects in the wild that use this. See for instance the case of PyWeakRef_GetObject where we delayed the removal for now until less projects are using it. And also, we should coordinate with the compat project. Finally, add a section for this removal in What's New as well as possible fallbacks.

xuantengh commented Jul 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please check if there are projects in the wild that use this.

I have some rough and preliminary search in GitHub and find some projects like:

still use these C functions.

I can have a more detail exploration for popular PyPI packages later.

xuantengh commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz I search the top 300 popular PyPI packages and find PySys_SetArgv appears in the following 2:

picnixz commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Well cython is a major project that we don't want to break. orjson is, iirc, simd-accelerated JSON so we don't want to break it either. They should first upgrade their code and then we'll remove the functions on our side I think.

github-actions Bot commented Apr 26, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 26, 2026
This was referenced Jul 27, 2026
Open
Open
ambv mentioned this pull request Oct 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba left review comments
ZeroIntensity ZeroIntensity left review comments
encukou Awaiting requested review from encukou encukou is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time. topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL