FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109700: fix interp finalization while handling memory error by kumaraditya303 · Pull Request #136342 · python/cpython · GitHub

/ cpython Public

gh-109700: fix interp finalization while handling memory error - #136342

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:interp
Jul 7, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-109700: fix interp finalization while handling memory error#136342
kumaraditya303 merged 1 commit into
python:mainfrom
kumaraditya303:interp

Conversation

kumaraditya303 commented Jul 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Jul 6, 2025
Closed

kumaraditya303 commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot refleak*

bedevere-bot commented Jul 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit ba1e603 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136342%2Fmerge

The command will test the builders whose names match following regular expression: refleak*

The builders matched are:

  • AMD64 RHEL8 Refleaks PR
  • AMD64 Fedora Rawhide NoGIL refleaks PR
  • AMD64 CentOS9 Refleaks PR
  • s390x RHEL9 Refleaks PR
  • s390x Fedora Stable Refleaks PR
  • s390x Fedora Rawhide NoGIL refleaks PR
  • s390x Fedora Rawhide Refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • aarch64 Fedora Rawhide Refleaks PR
  • AMD64 Windows11 Refleaks PR
  • PPC64LE Fedora Rawhide Refleaks PR
  • AMD64 Fedora Stable Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR
  • AMD64 FreeBSD Refleaks PR
  • s390x RHEL8 Refleaks PR
  • AMD64 Fedora Rawhide Refleaks PR
  • aarch64 RHEL8 Refleaks PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • PPC64LE RHEL8 Refleaks PR
  • aarch64 CentOS9 Refleaks PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 Fedora Rawhide NoGIL refleaks PR

serhiy-storchaka self-requested a review July 6, 2025 18:10
serhiy-storchaka approved these changes Jul 7, 2025
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM in principle. I afraid that calling Py_EndInterpreter() can introduce other crashes, because more clean up code can now be executed for not yet initialized parts. There are two ways to solve this:

  • Make Py_EndInterpreter() super robust.
  • Only call these clean up procedures which are necessary after each error.

In any way, it would be better to fix all potential crashes in one go. But if you prefer, you can merge this PR.

kumaraditya303 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Make Py_EndInterpreter() super robust.

I would prefer to do that, it is better for user code too as it is public API but can be done after this.

kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 7, 2025
kumaraditya303 merged commit 0c3e3da into python:main Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

kumaraditya303 deleted the interp branch July 7, 2025 07:15
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
36809ab 
…rror (pythonGH-136342)

(cherry picked from commit 0c3e3da)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
981fce1 
…rror (pythonGH-136342)

(cherry picked from commit 0c3e3da)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136352 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136353 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 7, 2025
kumaraditya303 added a commit that referenced this pull request Jul 7, 2025
[3.13] gh-109700: fix interpreter finalization while handling memory …
2362cb6 
…error (GH-136342) (#136353)

gh-109700: fix interpreter finalization while handling memory error (GH-136342)
(cherry picked from commit 0c3e3da)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jul 7, 2025
[3.14] gh-109700: fix interpreter finalization while handling memory …
22fad16 
…error (GH-136342) (#136352)

gh-109700: fix interpreter finalization while handling memory error (GH-136342)
(cherry picked from commit 0c3e3da)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
25ca248 
…rror (python#136342)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
3b8bc87 
…rror (python#136342)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
e7a8024 
…rror (python#136342)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
2282892 
…rror (python#136342)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-109700: fix interpreter finalization while handling memory e…
f76985b 
…rror (python#136342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL