FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136355: Deprecate `-b` and `-bb` CLI flags in 3.15 by sobolevn · Pull Request #136363 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136355: Deprecate -b and -bb CLI flags in 3.15 - #136363

Merged
sobolevn merged 8 commits into
python:mainfrom
sobolevn:issue-136355
Sep 14, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-136355: Deprecate -b and -bb CLI flags in 3.15#136363
sobolevn merged 8 commits into
python:mainfrom
sobolevn:issue-136355

Conversation

sobolevn commented Jul 7, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

sobolevn requested review from hugovk, malemburg and vstinner July 7, 2025 09:33
bedevere-app Bot mentioned this pull request Jul 7, 2025
Closed
StanFromIreland reviewed Jul 7, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be added to pending-removal-in-3.17.rst?

Also, -bb is not documented and must be unliked/escaped (I don't know what to call: !) to stop errors.

vstinner reviewed Jul 7, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated
Comment thread Python/initconfig.c Outdated
Comment thread Python/initconfig.c Outdated
malemburg requested changes Jul 7, 2025
View reviewed changes

malemburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Apart from the wording changes, this LGTM.

Comment thread Doc/whatsnew/3.15.rst

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

malemburg reviewed Jul 7, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst
hugovk reviewed Jul 7, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
vstinner reviewed Aug 5, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you update the PR to not emit a deprecation warning and not schedule the flag removal?

Can you also deprecate PyConfig.bytes_warning member in the doc? https://docs.python.org/dev/c-api/init_config.html#c.PyConfig.bytes_warning

sobolevn requested a review from AA-Turner as a code owner September 10, 2025 15:50
vstinner reviewed Sep 10, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated
sobolevn requested a review from FFY00 as a code owner September 10, 2025 16:04

sobolevn commented Sep 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Done! I addressed all feedback: now we no longer plan to remove -b and -bb, we will only be making them no-op. No warning is raised.

Please, take another look :)

vstinner reviewed Sep 11, 2025
View reviewed changes
Comment thread Doc/c-api/init_config.rst Outdated
Comment thread Doc/using/cmdline.rst Outdated
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-07-07-12-24-00.gh-issue-136355.MTcA8j.rst Outdated

malemburg commented Sep 11, 2025

Copy link
Copy Markdown
Member

I don't think we should remove these options anytime soon. Why possibly break code that's using them ?

Instead, we could simply remove the documentation and make them no-ops, but still accept them on the command line.

vstinner reviewed Sep 11, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-07-07-12-24-00.gh-issue-136355.MTcA8j.rst Outdated
Comment thread Doc/c-api/init_config.rst Outdated
sobolevn and others added 2 commits September 14, 2025 14:44
Update Doc/c-api/init_config.rst
7a27430 
Co-authored-by: Victor Stinner <vstinner@python.org>
Adress review
3eb2974
StanFromIreland reviewed Sep 14, 2025
View reviewed changes
Comment thread Doc/c-api/init_config.rst Outdated
Comment thread Doc/using/cmdline.rst
Update Doc/c-api/init_config.rst
117872f 
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

StanFromIreland commented Sep 14, 2025

Copy link
Copy Markdown
Member

FYI bedevere is still waiting for changes: #136363 (comment)

sobolevn commented Sep 14, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again. To please the bot :)

bedevere-app Bot commented Sep 14, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@malemburg: please review the changes made to this pull request.

bedevere-app Bot requested a review from malemburg September 14, 2025 15:07
vstinner approved these changes Sep 14, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

malemburg requested changes Sep 14, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst

bedevere-app Bot commented Sep 14, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

malemburg approved these changes Sep 14, 2025
View reviewed changes

malemburg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I didn't see the original, just the suggestion. All good now.

StanFromIreland approved these changes Sep 14, 2025
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

sobolevn merged commit 1c984ba into python:main Sep 14, 2025
56 of 61 checks passed

sobolevn commented Sep 14, 2025

Copy link
Copy Markdown
Member Author

Thanks everyone! 👍

Liam-DeVoe mentioned this pull request Jun 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk left review comments
vstinner vstinner approved these changes
malemburg malemburg approved these changes
StanFromIreland StanFromIreland approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL