FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136492: Add `FrameLocalsProxyType` to `types` by ZeroIntensity · Pull Request #136546 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136492: Add FrameLocalsProxyType to types - #136546

Merged
ZeroIntensity merged 30 commits into
python:mainfrom
ZeroIntensity:frameslocalsproxy-types
Jul 20, 2025
ConversationCommits (30)ChecksFiles changed
Merged

gh-136492: Add FrameLocalsProxyType to types#136546
ZeroIntensity merged 30 commits into
python:mainfrom
ZeroIntensity:frameslocalsproxy-types

Conversation

ZeroIntensity commented Jul 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jul 11, 2025
Closed
picnixz reviewed Jul 11, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Lib/test/test_types.py Outdated

ZeroIntensity commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

Ugh, those test failures look like an existing bug on FrameLocalsProxy.

This comment was marked as spam.

Sign in to view

picnixz commented Jul 11, 2025

Copy link
Copy Markdown
Member

@python/organization-owners Could you block blockchainGuru1018 for spam & misguided reviews? TiA.

gaogaotiantian reviewed Jul 11, 2025
View reviewed changes
Comment thread Doc/library/types.rst Outdated
gaogaotiantian reviewed Jul 11, 2025
View reviewed changes
Comment thread Doc/library/types.rst Outdated

gaogaotiantian commented Jul 11, 2025

Copy link
Copy Markdown
Member

Ugh, those test failures look like an existing bug on FrameLocalsProxy.

Could you be more specific? Maybe raise an issue for that so I can fix it later?

ZeroIntensity commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

Could you be more specific? Maybe raise an issue for that so I can fix it later?

There were a few things I had to skip in test_inspect. I think they're bugs, but I haven't investigated the test enough to be sure.

gaogaotiantian commented Jul 11, 2025

Copy link
Copy Markdown
Member

Okay now we need some typing expert to review this. @JelleZijlstra maybe?

ZeroIntensity commented Jul 12, 2025

Copy link
Copy Markdown
Member Author

I'd also appreciate it if @AA-Turner could take a look; he's done some recent work with types and _types.

JelleZijlstra commented Jul 12, 2025

Copy link
Copy Markdown
Member

You don't really need a static typing expert for the types module; it predates static typing and is useful even without static typing. The PR seems pretty straightforward to me.

JelleZijlstra reviewed Jul 12, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Outdated
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/types.py Outdated
Update Doc/whatsnew/3.15.rst
fb710eb 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AA-Turner reviewed Jul 15, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-07-11-10-23-44.gh-issue-136492.BVi5h0.rst Outdated
Comment thread Doc/library/types.rst Outdated
Comment thread Lib/test/test_types.py Outdated
'MethodDescriptorType', 'MethodType', 'MethodWrapperType',
'ModuleType', 'NoneType', 'NotImplementedType', 'SimpleNamespace',
'TracebackType', 'UnionType', 'WrapperDescriptorType',
'FrameLocalsProxyType'

AA-Turner Jul 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please keep the list sorted (GH doesn't let me add a suggestion)

ZeroIntensity Jul 15, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I had that originally but @picnixz had reservations about it.

AA-Turner Jul 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it's better to keep the list sorted rather than attempt to minimise 3-4 lines of diff here.

ZeroIntensity Jul 15, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed.

picnixz Jul 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My suggestion was to keep it sorted but by just adding the export on its own line.

ZeroIntensity Jul 20, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, missed this. I've updated it now; does that look better?

Comment thread Lib/test/test_types.py Outdated
Comment thread Lib/types.py Outdated
Comment thread Objects/frameobject.c
Comment thread Doc/whatsnew/3.15.rst Outdated
Apply suggestions from code review
7a649c2 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner changed the title gh-136492: Add FrameLocalsProxy to types gh-136492: Add FrameLocalsProxyType to types Jul 15, 2025
AA-Turner reviewed Jul 20, 2025
View reviewed changes
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
AA-Turner approved these changes Jul 20, 2025
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

A

Comment thread Objects/frameobject.c Outdated
Update frameobject.c
63e263e 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

ZeroIntensity commented Jul 20, 2025

Copy link
Copy Markdown
Member Author

Any final objections before I merge this?

AA-Turner commented Jul 20, 2025

Copy link
Copy Markdown
Member

All good with me.

A

ZeroIntensity merged commit 8f59fbb into python:main Jul 20, 2025
ZeroIntensity deleted the frameslocalsproxy-types branch July 20, 2025 18:49
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-136492: Add FrameLocalsProxyType to types (pythonGH-136546)
bb70585 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-136492: Add FrameLocalsProxyType to types (pythonGH-136546)
b4e0f1a 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
picnixz picnixz left review comments
gaogaotiantian gaogaotiantian left review comments
AA-Turner AA-Turner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
+1 more reviewer
blockchainGuru1018 blockchainGuru1018 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL