Repository navigation
gh-101100: Resolve reference warnings in library/xml.sax.handler.rst - #136612
Merged
AA-Turner merged 5 commits intoSep 3, 2025
Merged
AA-Turner merged 5 commits into
AA-Turner merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
picnixz
reviewed
Jul 14, 2025
Comment thread
Doc/library/xml.sax.handler.rst
Outdated
LamentXU123
marked this pull request as draft
July 14, 2025 15:21
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
LamentXU123
marked this pull request as ready for review
July 14, 2025 15:27
AA-Turner
approved these changes
Sep 3, 2025
Copy link
Copy Markdown
|
Thanks @LamentXU123 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2025
…r.rst (pythonGH-136612) (cherry picked from commit c22cc8f) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2025
…r.rst (pythonGH-136612) (cherry picked from commit c22cc8f) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-138421 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-138422 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
AA-Turner
pushed a commit
that referenced
this pull request
Sep 3, 2025
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
….handler.rst (pythonGH-136612) (python#138421) pythongh-101100: Resolve reference warnings in library/xml.sax.handler.rst (pythonGH-136612) (cherry picked from commit c22cc8f) Co-authored-by: Weilin Du <108666168+LamentXU123@users.noreply.github.com>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two warnings:
This warning happens in many doc of xml (xml.sax.reader, xml.sax.handler, xml.sax) in the same reason. After staring the doc for a while, I think the original doc want to refer to xml.sax.xmlreader.AttributesImpl and xml.sax.xmlreader.AttributesNSImpl as an implemention of attributes-interface. This doc fix it to the correct ref.
If this is approved, I will fix up those occurrence in other docs, an example of this in xml.sax is as below to double check.
📚 Documentation preview 📚: https://cpython-previews--136612.org.readthedocs.build/