FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136787: raise consistent ValueError for bad hashes by picnixz · Pull Request #136802 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136787: raise consistent ValueError for bad hashes - #136802

Merged
picnixz merged 6 commits into
python:mainfrom
picnixz:feat/hashlib/same-error-messages-136787
Jul 20, 2025
ConversationCommits (6)ChecksFiles changed
Merged

gh-136787: raise consistent ValueError for bad hashes#136802
picnixz merged 6 commits into
python:mainfrom
picnixz:feat/hashlib/same-error-messages-136787

Conversation

picnixz commented Jul 19, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Jul 19, 2025
Closed

picnixz commented Jul 19, 2025

Copy link
Copy Markdown
Member Author

For now, I'm adding a skip news just to run the builbots. I'll come back tomorrow.

picnixz commented Jul 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

This comment was marked as resolved.

Sign in to view
picnixz force-pushed the feat/hashlib/same-error-messages-136787 branch from d2fa695 to db6f4db Compare July 19, 2025 12:05

picnixz commented Jul 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Jul 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit db6f4db 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136802%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz marked this pull request as ready for review July 19, 2025 17:45
picnixz requested review from gpshead and tiran as code owners July 19, 2025 17:45
gpshead reviewed Jul 19, 2025
View reviewed changes

gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

overall good, mostly little details in comments or naming

Comment thread Modules/_hashopenssl.c Outdated
Comment thread Modules/_hashopenssl.c Outdated
Comment thread Modules/_hashopenssl.c Outdated
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Outdated
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Outdated
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Outdated
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Outdated
picnixz commented Jul 19, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Outdated

picnixz commented Jul 19, 2025

Copy link
Copy Markdown
Member Author

I really should avoid using the web editor. I'll make the changes tomorrow.

picnixz enabled auto-merge (squash) July 20, 2025 08:24
picnixz disabled auto-merge July 20, 2025 08:25
picnixz enabled auto-merge (squash) July 20, 2025 08:25
picnixz merged commit 6be49ee into python:main Jul 20, 2025
picnixz deleted the feat/hashlib/same-error-messages-136787 branch July 20, 2025 08:52
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-136787: improve exception messages for invalid hash algorith…
9e3971e 
…ms (python#136802)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-136787: improve exception messages for invalid hash algorith…
ac38a74 
…ms (python#136802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead left review comments
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL