Repository navigation
gh-136640: Clarify the documentation of the AST module - #136868
Closed
mlnrt wants to merge 2 commits into
Closed
mlnrt wants to merge 2 commits into
mlnrt wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AA-Turner
approved these changes
Jul 20, 2025
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thanks @mlnrt for working on this during the EuroPython sprints! I'll wait for an AST expert to review before merging. cc: @JelleZijlstra @Eclips4
A
Sorry, something went wrong.
Comment thread
Doc/library/ast.rst
| :attr:`end_col_offset` attributes. The :attr:`lineno` and :attr:`end_lineno` | ||
| are the first and last line numbers of source text span (1-indexed so the | ||
| first line is line 1) and the :attr:`col_offset` and :attr:`end_col_offset` | ||
| Most classes part of the AST module have the :attr:`lineno`, :attr:`col_offset`, |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| Most classes part of the AST module have the :attr:`lineno`, :attr:`col_offset`, | |
| Most classes in the :mod:`!ast` module have the :attr:`lineno`, :attr:`col_offset`, |
Sorry, something went wrong.
Comment thread
Doc/library/ast.rst
| are the first and last line numbers of source text span (1-indexed so the | ||
| first line is line 1) and the :attr:`col_offset` and :attr:`end_col_offset` | ||
| Most classes part of the AST module have the :attr:`lineno`, :attr:`col_offset`, | ||
| :attr:`end_lineno`, and :attr:`end_col_offset` attributes, including subclasses of |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| :attr:`end_lineno`, and :attr:`end_col_offset` attributes, including subclasses of | |
| :attr:`end_lineno`, and :attr:`end_col_offset` attributes, including all subclasses of |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@AA-Turner no. I just deleted my fork of cpython. I did not realized it would close this |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies the documentation describing the attributes of classes part of the AST module
📚 Documentation preview 📚: https://cpython-previews--136868.org.readthedocs.build/