FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-137007: Track executor before any possible deallocations by Fidget-Spinner · Pull Request #137016 · python/cpython · GitHub

/ cpython Public

gh-137007: Track executor before any possible deallocations - #137016

Merged
Fidget-Spinner merged 8 commits into
python:mainfrom
Fidget-Spinner:track-before-deallocating
Dec 10, 2025
ConversationCommits (8)ChecksFiles changed
Merged

gh-137007: Track executor before any possible deallocations#137016
Fidget-Spinner merged 8 commits into
python:mainfrom
Fidget-Spinner:track-before-deallocating

Conversation

Fidget-Spinner commented Jul 22, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fidget-Spinner requested review from brandtbucher and removed request for markshannon July 22, 2025 16:18
bedevere-app Bot mentioned this pull request Jul 22, 2025
Closed
Fidget-Spinner commented Jul 22, 2025
View reviewed changes
Comment thread Python/optimizer.c
@@ -1234,7 +1238,6 @@ make_executor_from_uops(_PyUOpInstruction *buffer, int length, const _PyBloomFil
return NULL;

Fidget-Spinner Jul 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note to reviewers: the bad dealloc happens right above this line at line 1233/1238 depending on which diff you view.

Fidget-Spinner commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

There's no reproducer because I can't force _PyJIT_Compile to fail except in specific scenarios, or when the GC decides to kick in right when the executor is linked, but not yet tracked.

devdanzin commented Jul 22, 2025

Copy link
Copy Markdown
Member

Unfortunately the patch doesn't fix the issue for me. I double checked that it's applied and still get the abort. Investigating whether the diff necessary to reproduce is the same.

Fidget-Spinner commented Jul 22, 2025

Copy link
Copy Markdown
Member Author

@devdanzin can you please try again?

devdanzin commented Jul 22, 2025

Copy link
Copy Markdown
Member

Still aborting here. Does it stop reproducing for you?

picnixz mentioned this pull request Oct 11, 2025
Closed
picnixz reviewed Oct 11, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the other PR, when allocating the cold executor, there is an error path before making it immortal. Should we track the cold executor before it is immortal and untrack it before making it immortal?

Fidget-Spinner commented Nov 7, 2025

Copy link
Copy Markdown
Member Author

@devdanzin does it still reproduce now?

devdanzin commented Nov 9, 2025

Copy link
Copy Markdown
Member

Unfortunately I cannot reproduce the crash even without the patch applied. Tried all known MREs, tinkered with them for over two hours to try to make them repro, and fuzzed with the MREs as seeds. No luck reproducing.

ashm-dev mentioned this pull request Dec 10, 2025
Merged
markshannon approved these changes Dec 10, 2025
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good.

I'm a bit surprised that the first commit didn't fix this. Did you find out why that was?

Fidget-Spinner merged commit 97e1901 into python:main Dec 10, 2025
64 checks passed
Fidget-Spinner added the needs backport to 3.14 bugs and security fixes label Dec 10, 2025

miss-islington-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2025
pythongh-137007: Track executor before any possible deallocations (py…
25a48d9 
…thonGH-137016)

(cherry picked from commit 97e1901)

Co-authored-by: Ken Jin <kenjin@python.org>

bedevere-app Bot commented Dec 10, 2025

Copy link
Copy Markdown

GH-142541 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Dec 10, 2025
Fidget-Spinner added a commit that referenced this pull request Dec 10, 2025
[3.14] gh-137007: Track executor before any possible deallocations (G…
acd5b97 
…H-137016) (GH-142541)

gh-137007: Track executor before any possible deallocations (GH-137016)
(cherry picked from commit 97e1901)

Co-authored-by: Ken Jin <kenjin@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

picnixz picnixz left review comments
markshannon markshannon approved these changes
brandtbucher Awaiting requested review from brandtbucher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL