FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133296: Fix versionadded for C API functions that were backported by ngoldbaum · Pull Request #137024 · python/cpython · GitHub

/ cpython Public

gh-133296: Fix versionadded for C API functions that were backported #137024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 1 commit into from
Jul 22, 2025
Conversation 3 Commits 1 Checks 34 Files changed
Merged

gh-133296: Fix versionadded for C API functions that were backported #137024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .rst  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 3 additions & 3 deletions Doc/c-api/init.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2287,7 +2287,7 @@ The C-API provides a basic mutual exclusion lock.
should not be used to make concurrency control decisions, as the lock
state may change immediately after the check.

.. versionadded:: next
.. versionadded:: 3.14

.. _python-critical-section-api:

Expand Down Expand Up @@ -2372,7 +2372,7 @@ code triggered by the finalizer blocks and calls :c:func:`PyEval_SaveThread`.

On the default build, this macro expands to ``{``.

.. versionadded:: next
.. versionadded:: 3.14

.. c:macro:: Py_END_CRITICAL_SECTION()

Expand Down Expand Up @@ -2418,7 +2418,7 @@ code triggered by the finalizer blocks and calls :c:func:`PyEval_SaveThread`.

On the default build, this macro expands to ``{``.

.. versionadded:: next
.. versionadded:: 3.14

.. c:macro:: Py_END_CRITICAL_SECTION2()

Expand Down
1 change: 1 addition & 0 deletions Doc/whatsnew/3.14.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3035,6 +3035,7 @@ Porting to Python 3.14
* ``_Py_GetConfig()``: :c:func:`PyConfig_Get` and :c:func:`PyConfig_GetInt`
* ``_Py_HashBytes()``: :c:func:`Py_HashBuffer`
* ``_Py_fopen_obj()``: :c:func:`Py_fopen`
* ``PyMutex_IsLocked()`` : :c:func:`PyMutex_IsLocked`

hugovk Jul 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should the first one start with an underscore?

ZeroIntensity Jul 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nope, the private API lacked a leading underscore.

hugovk Aug 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Then I need to undo my typo "fix" :)

#137525

The `pythoncapi-compat project`_ can be used to get most of these new
functions on Python 3.13 and older.
Expand Down
2 changes: 0 additions & 2 deletions Doc/whatsnew/3.15.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -504,8 +504,6 @@ Porting to Python 3.15

* Private functions promoted to public C APIs:

* ``PyMutex_IsLocked()`` : :c:func:`PyMutex_IsLocked`

The |pythoncapi_compat_project| can be used to get most of these new
functions on Python 3.14 and older.

Expand Down
Loading
Back | FazBrowse Home | New Git URL