FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-136306: fix `test_ssl.ContextTests.test_set_groups` on FIPS builds by picnixz · Pull Request #137405 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-136306: fix test_ssl.ContextTests.test_set_groups on FIPS builds - #137405

Merged
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/ssl/set-groups-fips-136306
Aug 5, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-136306: fix test_ssl.ContextTests.test_set_groups on FIPS builds#137405
picnixz merged 2 commits into
python:mainfrom
picnixz:fix/ssl/set-groups-fips-136306

Conversation

picnixz commented Aug 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

picnixz requested a review from gpshead as a code owner August 5, 2025 07:07
bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Aug 5, 2025

picnixz commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-app Bot mentioned this pull request Aug 5, 2025
Closed

bedevere-bot commented Aug 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 220f043 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137405%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only

bedevere-bot commented Aug 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit c036867 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137405%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

picnixz enabled auto-merge (squash) August 5, 2025 07:48
picnixz merged commit 0af7556 into python:main Aug 5, 2025
picnixz deleted the fix/ssl/set-groups-fips-136306 branch August 5, 2025 07:51
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-136306: fix test_ssl.ContextTests.test_set_groups on FIPS …
fa8e03f 
…builds (python#137405)

X25519 is not a valid curve if OpenSSL is built with FIPS mode,
and ignoring unknown groups in `SSL_CTX_set1_groups_list()`
is only supported since OpenSSL 3.3, so we use two curves that
are known to be FIPS-compliant, namely P-256 and P-384.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL