gh-124111: test macOS CI with Tk 9 - #137424
Merged
ned-deily merged 3 commits intoOct 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the good news! By the way, Tcl/Tk 9.0.2 was released on July 2. |
Sorry, something went wrong.
ned-deily
approved these changes
Oct 14, 2025
Copy link
Copy Markdown
Member
Author
|
Should we backport? In #124111 (comment), @serhiy-storchaka said:
So backport the test changes to 3.13, but leave macOS CI on tcl-tk@8? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Probably. And backport the whole PR to 3.14. But it might be good to wait for 3.15.0a1 to get out the door first. |
Sorry, something went wrong.
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 11, 2026
…3484) Backport the test-only parts of the Tcl/Tk 8.7/9.0/9.1 test adaptations so that test_tkinter and test_ttk pass when Python 3.13 is built against Tcl/Tk 9.0 (for example the Homebrew build used on macOS), while still passing against the Tcl/Tk 8.6 that 3.13 ships. Combines the test changes from: * gh-124111: Update tkinter for compatibility with Tcl/Tk 9.0.0 (GH-124156) * gh-124111: test macOS CI with Tk 9 (GH-137424) * gh-145736: Fix Tkinter tests for Tk 8.7, 9.0 and 9.1 (GH-145738) The corresponding non-test changes (Modules/_tkinter.c, Lib/tkinter/ttk.py, PCbuild and CI configuration) are not backported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes #136959 and fixes the tests for Tcl/Tk 9.
New PR because I couldn't push to that one:
Details