GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py - #137622
Merged
AA-Turner merged 3 commits intoSep 17, 2025
Merged
GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py#137622AA-Turner merged 3 commits into
AA-Turner merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AA-Turner
commented
Aug 10, 2025
Comment thread
Tools/c-analyzer/cpython/_parser.py
Outdated
AA-Turner
commented
Aug 10, 2025
Comment thread
Tools/c-analyzer/cpython/_parser.py
Outdated
ericsnowcurrently
approved these changes
Sep 17, 2025
ericsnowcurrently
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM (with your own suggested changes applied)
Sorry, something went wrong.
Comment thread
Tools/c-analyzer/cpython/_parser.py
# Conflicts: # Tools/c-analyzer/cpython/_parser.py
Copy link
Copy Markdown
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 7, 2025
…r.py`` (pythonGH-137622) (cherry picked from commit 2212ae5) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-139718 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to avoid some of the problems we've seen with embedded tabs by changing the global variables within c-analyzer/cpython/_parser.py to use more structured data.
The output is identical, save for INCL_DIRS, where the fourth line (* ./Include/internal/mimalloc) currently uses spaces instead of tabs, showing that the current format is quite hard to properly keep up to date. The errant line was added in #109914.
What do you think @ericsnowcurrently?
See also: