GH-137623: Begin enforcing docstring length in Argument Clinic - #137624
Merged
AA-Turner merged 9 commits intoAug 12, 2025
Merged
GH-137623: Begin enforcing docstring length in Argument Clinic#137624AA-Turner merged 9 commits into
AA-Turner merged 9 commits into
Conversation
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think that we should check the length for all lines, not only the first one. And the limit should be 72 for functions, __new__ and __init__, and 68 for other methods.
Also, should this be an error or warning?
Sorry, something went wrong.
Comment thread
Tools/clinic/libclinic/errors.py
Outdated
Comment thread
Tools/clinic/libclinic/dsl_parser.py
Outdated
Comment thread
Tools/clinic/libclinic/_overlong_docstrings.py
Comment thread
Tools/clinic/libclinic/errors.py
Outdated
AA-Turner
enabled auto-merge (squash)
August 12, 2025 19:05
Comment thread
Tools/clinic/libclinic/function.py
Outdated
AA-Turner
disabled auto-merge
August 12, 2025 19:38
AA-Turner
enabled auto-merge (squash)
August 12, 2025 19:52
serhiy-storchaka
approved these changes
Aug 12, 2025
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
skirpichev
added a commit
to skirpichev/cpython
that referenced
this pull request
Aug 13, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.