[3.14] gh-137226: Fix behavior of ForwardRef.evaluate with type_params (GH-137227) - #137709
Merged
hugovk merged 1 commit intoAug 13, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…pythonGH-137227) The previous behavior was copied from earlier typing code. It works around the way typing.get_type_hints passes its namespaces, but I don't think the behavior is logical or correct. (cherry picked from commit 089a324) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington
requested review from
AlexWaygood and
JelleZijlstra
as code owners
August 13, 2025 13:47
This was referenced Aug 13, 2025
JelleZijlstra
approved these changes
Aug 13, 2025
Copy link
Copy Markdown
Member
|
@hugovk is it still possible to get this in? |
Sorry, something went wrong.
ncoghlan
approved these changes
Aug 13, 2025
ncoghlan
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Yep! |
Sorry, something went wrong.
hugovk
enabled auto-merge (squash)
August 13, 2025 13:54
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…_params (pythonGH-137227) (python#137709) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior was copied from earlier typing code. It works around the way
typing.get_type_hints passes its namespaces, but I don't think the behavior is logical
or correct.
(cherry picked from commit 089a324)
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com