gh-135676: Reword the Operators & Delimiters section(s) - #137713
Merged
encukou merged 9 commits intoSep 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
reviewed
Aug 13, 2025
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
encukou
marked this pull request as draft
August 20, 2025 16:06
Copy link
Copy Markdown
Member
Author
|
So, I looked at this and #99000 again, and found a better (IMO) way to present the information. What do you think? What this PR is missing now is information from some existing notes:
I'll try adding a section for that next week. |
Sorry, something went wrong.
encukou
marked this pull request as ready for review
August 27, 2025 15:40
AA-Turner
approved these changes
Sep 3, 2025
Comment thread
Doc/reference/lexical_analysis.rst
AA-Turner
reviewed
Sep 3, 2025
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
Comment on lines
+1374
to
+1381
| | arithmetic_operator | ||
| | bitwise_operator | ||
| | comparison_operator | ||
| | enclosing_delimiter | ||
| | other_delimiter | ||
| | assignment_operator | ||
| | other_op | ||
| | "..." |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Should e.g. assignment op be higher? += is a longer string than +.
Sorry, something went wrong.
AA-Turner
reviewed
Sep 3, 2025
Comment thread
Doc/reference/lexical_analysis.rst
Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 3, 2025
…GH-137713) (cherry picked from commit cfcfbdd) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-138457 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…GH-137713) Co-authored-by: Blaise Pabon <blaise@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk
pushed a commit
that referenced
this pull request
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexically, there is no difference between operators and delimiters, so I combined the section.
This section also serves as a kind of guide for what all the ASCII "symbol" characters do, with notes like “The period can also occur in floating-point and imaginary literals” and “The following printing ASCII characters are not used in Python”.
I've expanded the notes to include @, {, etc., but (for now) stopped short of adding a table of ASCII characters with links to where they appear.
The tables of symbols are reorganized slightly.
. was added to operators (like @, it can be either operator or delimiter).
-> was moved from augmented assignment to delimiters.
📚 Documentation preview 📚: https://cpython-previews--137713.org.readthedocs.build/