FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-132339: Add support for OpenSSL 3.5 by zware · Pull Request #137720 · python/cpython · GitHub

Repository navigation

gh-132339: Add support for OpenSSL 3.5 - #137720

Merged
zware merged 8 commits into
python:mainfrom
zware:ssl35
Aug 14, 2025
Merged

zware merged 8 commits into
python:mainfrom
zware:ssl35

Conversation

zware commented Aug 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Includes _ssl_data*.h update, as well as updating other versions in CI.

Comment thread Tools/ssl/multissltests.py Outdated
Comment thread .github/workflows/build.yml Outdated
zware marked this pull request as ready for review August 13, 2025 17:43
gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Aug 14, 2025
zware merged commit 7a703c8 into python:main Aug 14, 2025
zware deleted the ssl35 branch August 14, 2025 04:18

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

Copy link
Copy Markdown

Sorry, @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.14

Copy link
Copy Markdown

Sorry, @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.13

zware added a commit to zware/cpython that referenced this pull request Aug 14, 2025
* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
(cherry picked from commit 7a703c8)

Co-authored-by: Zachary Ware <zach@python.org>

bedevere-app Bot commented Aug 14, 2025

Copy link
Copy Markdown

GH-137747 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025

zware commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

The 3.13 backport is complicated by the fact that 3.4 support was not backported there; presumably we want to do that first? I think we do want to make sure 3.5 at least works back to 3.13 (maybe even further?), but how critical is the _ssl_data*.h update for that?

cc: @encukou from GH-127330 (3.4) and @picnixz from GH-131618 (3.4.1)

hugovk pushed a commit that referenced this pull request Aug 14, 2025
* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
(cherry picked from commit 7a703c8)

This comment was marked as off-topic.

encukou commented Aug 14, 2025

Copy link
Copy Markdown
Member

The ssl_data*.h is only used for error messages.

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Copy Markdown
Member

Reminder about backporting. @zware

zware commented Aug 14, 2025

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: See note above; I'm not certain how we want to handle this.

encukou commented Aug 15, 2025

Copy link
Copy Markdown
Member

See #127331 (comment).

encukou removed the needs backport to 3.13 only security fixes label Aug 15, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…python#137747)

* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
(cherry picked from commit 7a703c8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL