gh-131178: Use support.captured_stdout and support.captured_stderr - #137748
gh-131178: Use support.captured_stdout and support.captured_stderr#137748donbarbos wants to merge 5 commits into
Conversation
Sorry, something went wrong.
picnixz
left a comment
There was a problem hiding this comment.
Just change the recent CLI tests, not the rest. It produces too much churn otherwise. Serhiy was also against a global change
Sorry, something went wrong.
Ok, and I found that test_unknown_flag in test_platform has assertStartsWith inside assertRaises, I hope you don't mind fixing it in the current PR |
Sorry, something went wrong.
|
Mmh, I really prefer separate commits as we could eventually not decide to change the capture_stdout() (I'll need to see the final changes and see if it's really a gain as there is also a backport question). There won't be an opposition to fixing the test but there might be slight opposition in refactoring. I am travelling now so I suggest fixing the test first, pinging a core dev such as Adam Turner for the merge and wait for me to come back for the capture_stdout() change. |
Sorry, something went wrong.
|
See #136632 for a previous discussion about changing tests to use the support.captured_* helpers. |
Sorry, something went wrong.
|
This is a code churn. Please leave it as is. |
Sorry, something went wrong.
I replaced contextlib.redicrect_std{out,err} and support.captured_output("std{out,err}") with support.captured_std{out,err}
Inspired by #131287 (comment). I went beyond older PRs, I thought that in other tests this change is also relevant