gh-95534: Convert ZlibDecompressor.__new__ to AC - #137923
Merged
AA-Turner merged 3 commits intoAug 19, 2025
Merged
Conversation
AA-Turner
commented
Aug 18, 2025
Comment thread
Modules/zlibmodule.c
picnixz
reviewed
Aug 18, 2025
Comment thread
Modules/zlibmodule.c
Comment thread
Modules/zlibmodule.c
Comment thread
Modules/zlibmodule.c
| {Py_tp_new, ZlibDecompressor__new__}, | ||
| {Py_tp_doc, (char *)ZlibDecompressor__new____doc__}, | ||
| {Py_tp_new, zlib__ZlibDecompressor}, | ||
| {Py_tp_doc, (char *)zlib__ZlibDecompressor__doc__}, |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is something separate, but I think AC should give the possibility to create docstrings for class and module directives as well.
Sorry, something went wrong.
Comment thread
Modules/zlibmodule.c
picnixz
approved these changes
Aug 19, 2025
picnixz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.