FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138122: Implement PEP 799 by pablogsal · Pull Request #138142 · python/cpython · GitHub

/ cpython Public

gh-138122: Implement PEP 799 - #138142

Merged
pablogsal merged 10 commits into
python:mainfrom
pablogsal:gh-138122
Aug 27, 2025
ConversationCommits (10)ChecksFiles changed
Merged

gh-138122: Implement PEP 799#138142
pablogsal merged 10 commits into
python:mainfrom
pablogsal:gh-138122

Conversation

pablogsal commented Aug 25, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Aug 25, 2025
Closed
AA-Turner reviewed Aug 25, 2025
View reviewed changes
Comment thread Lib/profiling/__init__.py Outdated
Comment thread Lib/profiling/sampling/__init__.py Outdated
Comment thread Lib/profiling/sampling/__init__.py
Comment thread Lib/profiling/sampling/__main__.py
Comment thread Lib/profiling/tracing/__init__.py Outdated
Comment thread Lib/profiling/tracing/__init__.py Outdated
Comment thread Lib/profiling/tracing/__init__.py
Comment thread Lib/profiling/tracing/__main__.py Outdated
Comment thread Lib/profiling/tracing/__init__.py Outdated
pablogsal and others added 3 commits August 26, 2025 15:57
Apply suggestions from code review
b2ec363 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Move stuff to common module
3277076
Fix lint
716dc9c

pablogsal commented Aug 26, 2025

Copy link
Copy Markdown
Member Author

@encukou do you happen to know what I am missing for android?

mhsmith commented Aug 26, 2025

Copy link
Copy Markdown
Member

I think profiling/tracing is missing from the directory list in Makefile.pre.in. Apparently Android is the only platform that runs the tests from a directory generated using make install.

AA-Turner reviewed Aug 26, 2025
View reviewed changes
Comment thread Makefile.pre.in Outdated
pablogsal and others added 2 commits August 26, 2025 23:14
Update Makefile.pre.in
1fa7d39 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Small fix
228133d
pablogsal commented Aug 27, 2025
View reviewed changes
Comment thread Lib/profiling/sampling/__init__.py Outdated
encukou reviewed Aug 27, 2025
View reviewed changes
Comment thread Lib/profiling/sampling/sample.py
pablogsal merged commit 56eb6b6 into python:main Aug 27, 2025
81 of 83 checks passed
pablogsal deleted the gh-138122 branch August 27, 2025 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou left review comments
AA-Turner AA-Turner left review comments
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL