FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138151: Fix `ForwardRef.evaluate()` for locally defined generics by dr-carlos · Pull Request #138161 · python/cpython · GitHub

/ cpython Public

gh-138151: Fix ForwardRef.evaluate() for locally defined generics - #138161

Closed
dr-carlos wants to merge 4 commits into
python:mainfrom
dr-carlos:forwardref-local-generic
ConversationCommits (4)ChecksFiles changed
Closed

gh-138151: Fix ForwardRef.evaluate() for locally defined generics#138161
dr-carlos wants to merge 4 commits into
python:mainfrom
dr-carlos:forwardref-local-generic

Conversation

dr-carlos commented Aug 26, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Fixes #138151 with new associated tests.
Could be some edge cases (not covered in the test suite) which it doesn't consider.

bedevere-app Bot commented Aug 26, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Aug 26, 2025
Closed

bedevere-app Bot commented Aug 27, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

JelleZijlstra commented Sep 6, 2025

Copy link
Copy Markdown
Member

I'd like to merge #138164 instead of this one.

dr-carlos commented Sep 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'd like to merge #138164 instead of this one.

Sounds good!

dr-carlos closed this Sep 6, 2025
dr-carlos deleted the forwardref-local-generic branch November 3, 2025 01:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

annotationlib: ref.evaluate() not working for generics as local variables

2 participants

Back | FazBrowse Home | New Git URL