FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138189: Document type slots, and other constants, as part of Limited API by encukou · Pull Request #138190 · python/cpython · GitHub

/ cpython Public

gh-138189: Document type slots, and other constants, as part of Limited API - #138190

Merged
encukou merged 9 commits into
python:mainfrom
encukou:document-slots
Nov 4, 2025
ConversationCommits (9)ChecksFiles changed
Merged

gh-138189: Document type slots, and other constants, as part of Limited API#138190
encukou merged 9 commits into
python:mainfrom
encukou:document-slots

Conversation

encukou commented Aug 27, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Aug 27, 2025
Closed
encukou marked this pull request as ready for review September 15, 2025 12:33

encukou commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

@ZeroIntensity, do you want to review this? It would help #141004 :)

ZeroIntensity approved these changes Nov 4, 2025
View reviewed changes

ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Happily!

I have one little nitpick about type annotations, but this looks good to me otherwise. Very happy to see these documented.

Comment thread Doc/tools/extensions/c_annotations.py Outdated
Comment thread Doc/tools/extensions/c_annotations.py Outdated
encukou and others added 2 commits November 4, 2025 22:14
ZeroIntensity mentioned this pull request Nov 4, 2025
Open

encukou commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

Thank you!

encukou merged commit d81e1ef into python:main Nov 4, 2025
46 checks passed
encukou deleted the document-slots branch November 4, 2025 21:58
encukou added the needs backport to 3.14 bugs and security fixes label Nov 4, 2025

miss-islington-app Bot commented Nov 4, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Nov 4, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d81e1ef0f3a7c63f5d246e4cf918700016b72489 3.14

ZeroIntensity mentioned this pull request Nov 5, 2025
Merged
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 6, 2025
[3.14] pythongh-138189: Document type slots, and other constants, as …
d15db04 
…part of Limited API (pythonGH-138190)

(cherry picked from commit d81e1ef)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>

bedevere-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141131 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
encukou added a commit that referenced this pull request Nov 6, 2025
[3.14] gh-138189: Document type slots, and other constants, as part o…
7168553 
…f Limited API (GH-138190) (GH-141131)

(cherry picked from commit d81e1ef)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
encukou added a commit to encukou/cpython that referenced this pull request Nov 7, 2025
[3.13] pythongh-138189: Document type slots, and other constants, as …
da30411 
…part of Limited API (pythonGH-138190)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
(cherry picked from commit d81e1ef)

bedevere-app Bot commented Nov 7, 2025

Copy link
Copy Markdown

GH-141193 is a backport of this pull request to the 3.13 branch.

encukou added a commit that referenced this pull request Nov 13, 2025
[3.13] gh-138189: Document type slots, and other constants, as part o…
6916bfb 
…f Limited API (GH-138190) (GH-141193)

(cherry picked from commit d81e1ef)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
pythongh-138189: Document type slots, and other constants, as part of…
d4039f4 
… Limited API (pythonGH-138190)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ZeroIntensity ZeroIntensity approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL