| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Yes, only strong references needs to be traversed. Also, why does _localdummy needs to be a gc type? It is an empty object so cannot be part of cycle, no? |
Sorry, something went wrong.
Even if it's "empty", the fact it's a heap type implies that it becomes a kind of "container" object as it has a reference to its type. At least, that's how the issue described the bug (and as the docs say). See also #87138 (comment). |
Sorry, something went wrong.
I agree, but the refcycle is only possible when the type is mutable then the cycle can be type -> some object -> instance -> type, if the type is immutable like this case then this isn't possible. |
Sorry, something went wrong.
|
Hum. So there are a number of PRs I opened that are actually not necessary. Because if I'm following you on this one, then some commits were also not necessary in the past (some of them added GC support for empty immutable types). |
Sorry, something went wrong.
Yes, some of them in the past where done in cases where it wasn't needed but we should not do more of it, doing it increases pressure on GC which will slow down performance. |
Sorry, something went wrong.
|
Ok, I will revert the PRs that touch immutable empty types. Sorry for the noise. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Did I correctly understand the fact that weakreflist should NOT be visited in the traverse function because the instance is not owning strong references to its elements here?
cc @kumaraditya303