gh-116946: Revert GC protocol for immutable empty heap types (GH-138266, GH-138288, GH-138289) - #138338
Merged
kumaraditya303 merged 3 commits intoSep 1, 2025
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
python#138266)" This reverts commit 9be91f6.
…ts (python#138288)" This reverts commit 3ea16f9.
…bjects (python#138289)" This reverts commit 6f1dd95.
kumaraditya303
approved these changes
Sep 1, 2025
Copy link
Copy Markdown
Member
Author
|
Thank you and sorry for the noise. |
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…ythonGH-138266, pythonGH-138288, pythonGH-138289) (python#138338) * Revert "pythongh-116946: fully implement GC protocol for `bz2` objects (python#138266)" This reverts commit 9be91f6. * Revert "pythongh-116946: fully implement GC protocol for `lzma` objects (python#138288)" This reverts commit 3ea16f9. * Revert "pythongh-116946: fully implement GC protocol for `_hashlib` objects (python#138289)" This reverts commit 6f1dd95.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commits 9be91f6, 3ea16f9 and 6f1dd95. I mistakenly assumed that immutable empty types also needed to support the GC protocol but this is not the case.