FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864) by miss-islington · Pull Request #138348 · python/cpython · GitHub

/ cpython Public

[3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864) - #138348

Merged
hugovk merged 1 commit into
python:3.14from
miss-islington:backport-6528cf4-3.14
Sep 7, 2025
ConversationCommits (1)ChecksFiles changed
Merged

[3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864)#138348
hugovk merged 1 commit into
python:3.14from
miss-islington:backport-6528cf4-3.14

Conversation

miss-islington commented Sep 1, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

pythongh-90548: Fix musl version detection with --strip-all (pythonGH…
d14afe3 
…-137864)

(cherry picked from commit 6528cf4)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This was referenced Sep 1, 2025
Closed
Merged
vstinner approved these changes Sep 1, 2025
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

cdce8p commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.

vstinner commented Sep 2, 2025

Copy link
Copy Markdown
Member

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.

This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release.

cdce8p commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.

This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release.

Ahh, I see. Tbh I had hoped it could still be included as it fixes a regression introduced in 6146295 (3.14.0a7). Without the fix I'll need to patch our alpine docker builds for 3.14.0.

vstinner commented Sep 2, 2025

Copy link
Copy Markdown
Member

cc @hugovk

hugovk merged commit d36c9a8 into python:3.14 Sep 7, 2025
52 checks passed
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
[3.14] pythongh-90548: Fix musl version detection with --strip-all (p…
da5f681 
…ythonGH-137864) (python#138348)

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington deleted the backport-6528cf4-3.14 branch January 2, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes

Assignees

hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL