gh-138013: Move I/O tests to test_io - #138365
Merged
vstinner merged 3 commits intoSep 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Centralize `io` tests into the `test_io` module so they are easier to find and work on. This will make it easier to split `test_general` which takes 30+ seconds in a debug build on my machine. This renames `test_bufio` to be `test_bufferedio` so that it matches the implementation file name (`bufferedio.c`). Validation performed: Tests are run in parallel after change: ```bash ./python.exe -m test test_io -uall,largefile,extralargefile -M12G -j8 ``` Docstring reformat in `test_io/__init__.py` looks reasonable: ```python >>> import test.test_io >>> help(test.test_io) ```
Copy link
Copy Markdown
Contributor
Author
|
Can this get skip news as its a test only change? |
Sorry, something went wrong.
vstinner
approved these changes
Sep 2, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
AA-Turner
reviewed
Sep 3, 2025
Comment thread
Lib/test/test_io/__init__.py
Outdated
Comment thread
Lib/test/test_io/__init__.py
Outdated
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
approved these changes
Sep 3, 2025
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
Centralize `io` tests into the `test_io` module so they are easier to find and work on. This will make it easier to split `test_general` which takes 30+ seconds in a debug build on my machine. This renames `test_bufio` to be `test_bufferedio` so that it matches the implementation file name (`bufferedio.c`). Validation performed: Tests are run in parallel after change: ```bash ./python.exe -m test test_io -uall,largefile,extralargefile -M12G -j8 ``` Docstring reformat in `test_io/__init__.py` looks reasonable: ```python >>> import test.test_io >>> help(test.test_io) ``` Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize io tests into the test_io module so they are easier to find and work on. This will make it easier to split test_general which takes 30+ seconds in a debug build on my machine.
This renames test_bufio to be test_bufferedio so that it matches the implementation file name (bufferedio.c).
Validation performed
Tests are run in parallel after change:
./python.exe -m test test_io -uall,largefile,extralargefile -M12G -j8Docstring reformat in test_io/__init__.py looks reasonable: