[3.14] gh-116946: fully implement GC protocol for _curses_panel.panel (GH-138333) - #138427
Merged
hugovk merged 1 commit intoSep 6, 2025
Merged
[3.14] gh-116946: fully implement GC protocol for _curses_panel.panel (GH-138333)#138427hugovk merged 1 commit into
hugovk merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…l.panel` (pythonGH-138333) This commit fixes possible reference loops via `panel.set_userptr` by implementing `tp_clear` and `tp_traverse` for panel objects. (cherry picked from commit 572df47) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced Sep 3, 2025
serhiy-storchaka
approved these changes
Sep 3, 2025
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. 👍
Sorry, something went wrong.
Comment thread
Modules/_curses_panel.c
| { | ||
| PyCursesPanelObject *po = PyObject_New(PyCursesPanelObject, | ||
| state->PyCursesPanel_Type); | ||
| assert(state != NULL); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
These asserts are redundant. Dereferencing a NULL pointer has a similar effect to a failed assert.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I actually added those asserts for debugging purposes. Since they are on main, I think it's better to reduce the diff.
Sorry, something went wrong.
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes possible reference loops via panel.set_userptr by implementing tp_clear and tp_traverse for panel objects. (cherry picked from commit 572df47)