Repository navigation
gh-129813, PEP 782: Use PyBytesWriter in _hashopenssl - #138922
Merged
vstinner merged 2 commits intoSep 15, 2025
Merged
vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Replace PyBytes_FromStringAndSize(NULL, size) with the new public PyBytesWriter API.
picnixz
reviewed
Sep 15, 2025
Copy link
Copy Markdown
Member
Author
|
@picnixz: Please review the updated code. |
Sorry, something went wrong.
picnixz
approved these changes
Sep 15, 2025
Copy link
Copy Markdown
Member
|
Wait, does Create overallocate the buffer? because in sha3 and hashopenssl we don't need extra bytes (we just need the exact size that is asked). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
PyBytesWrite_Create(n) allocates exactly n bytes, it doesn't use overallocation. Only PyBytesWriter_Grow() and PyBytesWriter_Resize() use overallocation. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace PyBytes_FromStringAndSize(NULL, size) with the new public PyBytesWriter API.