FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-137065: Revert "gh-105499: Merge typing.Union and types.UnionType (#105511)" by serhiy-storchaka · Pull Request #138967 · python/cpython · GitHub

/ cpython Public

gh-137065: Revert "gh-105499: Merge typing.Union and types.UnionType (#105511)" - #138967

Open
serhiy-storchaka wants to merge 2 commits into
python:mainfrom
serhiy-storchaka:revert-gh-105499
ConversationCommits (2)ChecksFiles changed
Open

gh-137065: Revert "gh-105499: Merge typing.Union and types.UnionType (#105511)"#138967
serhiy-storchaka wants to merge 2 commits into
python:mainfrom
serhiy-storchaka:revert-gh-105499

Conversation

serhiy-storchaka commented Sep 16, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This reverts commit d1db43c.
This reverts commit 0f511d8.
This reverts commit dc6d66f.

📚 Documentation preview 📚: https://cpython-previews--138967.org.readthedocs.build/

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Sep 16, 2025
bedevere-app Bot mentioned this pull request Sep 16, 2025
Open
pythongh-137065: Revert "pythongh-105499: Merge typing.Union and type…
5cd4a72 
…s.UnionType (python#105511)"

This reverts commit d1db43c.
This reverts commit 0f511d8.
This reverts commit dc6d66f.
serhiy-storchaka mentioned this pull request Sep 16, 2025
Draft

rhettinger commented Sep 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

I agree that this should be reverted. It would be too difficult to change after a release.

It looks like concerns were raised from the outset and were not resolved before the PR was applied.

hugovk commented Sep 18, 2025

Copy link
Copy Markdown
Member

SC decided on the status quo.

serhiy-storchaka commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

Do you mean restoring the status quo?

serhiy-storchaka commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

It is better to merge this PR earlier, because I may need a time to resolve conflicts with 3.14.

hugovk commented Sep 18, 2025

Copy link
Copy Markdown
Member

Sorry for the ambiguity. I meant keeping 3.14 as is, without this revert. The SC will post their decision later.

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 29, 2026
serhiy-storchaka added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 30, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

Release and Deferred blockers 🚫
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL