FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-135755: Make Py_TAIL_CALL_INTERP macro private by vstinner · Pull Request #138981 · python/cpython · GitHub

/ cpython Public

gh-135755: Make Py_TAIL_CALL_INTERP macro private - #138981

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:private_tail_cail
Sep 18, 2025
Merged

gh-135755: Make Py_TAIL_CALL_INTERP macro private#138981
vstinner merged 1 commit into
python:mainfrom
vstinner:private_tail_cail

Conversation

vstinner commented Sep 16, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

Copy link
Copy Markdown
Member Author

@Fidget-Spinner: I blindly replaced Py_TAIL_CALL_INTERP text with _Py_TAIL_CALL_INTERP. I didn't test my change.

Copy link
Copy Markdown
Member

Thanks. I'll approve once CI passes.

Copy link
Copy Markdown
Member Author

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

Copy link
Copy Markdown
Member

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

Don't worry, we have CI for the tail calling interpreter on most platforms, so you can just let it run :)

vstinner added the needs backport to 3.14 bugs and security fixes label Sep 17, 2025

Copy link
Copy Markdown
Member Author

Ping @Fidget-Spinner

Copy link
Copy Markdown
Member Author

@hugovk: This change mostly/only makes sense if it's backported to 3.14. Would you accept this late C API change in 3.14? It makes the macro private.

Copy link
Copy Markdown
Member Author

Maybe it's ok to leave the macro in 3.14 and remove it in 3.15. No one should rely on this macro :-)

vstinner merged commit 6504f20 into python:main Sep 18, 2025
82 checks passed
vstinner deleted the private_tail_cail branch September 18, 2025 12:33

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6504f20ccedf0b27275327e72698dee5f0c75ba8 3.14

miss-islington-app Bot assigned vstinner and unassigned hugovk Sep 18, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 18, 2025
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

(cherry picked from commit 6504f20)

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139120 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025

Copy link
Copy Markdown
Member Author

@Fidget-Spinner suggested me to merge this change in the main branch, so I did it :-)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL