[3.14] gh-128627: Use __builtin_wasm_test_function_pointer_signature for Emscripten trampoline (GH-137470) - #139039
Merged
hugovk merged 1 commit intoSep 17, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…or Emscripten trampoline (pythonGH-137470) With llvm/llvm-project#150201 being merged, there is now a better way to generate the Emscripten trampoline, instead of including hand-generated binary WASM content. Requires Emscripten 4.0.12. (cherry picked from commit 2629ee4) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
miss-islington
requested review from
corona10,
ericsnowcurrently,
erlend-aasland and
freakboy3742
as code owners
September 17, 2025 14:34
Copy link
Copy Markdown
Contributor
|
!buildbot emscripten |
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1118501 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139039%2Fmerge The command will test the builders whose names match following regular expression: emscripten The builders matched are:
|
Sorry, something went wrong.
freakboy3742
approved these changes
Sep 17, 2025
freakboy3742
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
👍
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Assigning to @hugovk while the merge block is in place. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With llvm/llvm-project#150201 being merged, there is
now a better way to generate the Emscripten trampoline, instead of including
hand-generated binary WASM content. Requires Emscripten 4.0.12.
(cherry picked from commit 2629ee4)
Co-authored-by: Hood Chatham roberthoodchatham@gmail.com