FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118803: Improve documentation around `ByteString` deprecation by AlexWaygood · Pull Request #139115 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-118803: Improve documentation around ByteString deprecation - #139115

Merged
AlexWaygood merged 4 commits into
python:mainfrom
AlexWaygood:alex/bad-bytestring
Sep 18, 2025
ConversationCommits (4)ChecksFiles changed
Merged

gh-118803: Improve documentation around ByteString deprecation#139115
AlexWaygood merged 4 commits into
python:mainfrom
AlexWaygood:alex/bad-bytestring

Conversation

AlexWaygood commented Sep 18, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

State more clearly why the ABC is scheduled for removal. State more clearly what the different options are that users should prefer instead.

📚 Documentation preview 📚: https://cpython-previews--139115.org.readthedocs.build/

AlexWaygood added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 18, 2025
bedevere-app Bot mentioned this pull request Sep 18, 2025
Closed
AlexWaygood requested a review from hugovk September 18, 2025 12:38
hugovk approved these changes Sep 18, 2025
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Outdated
AA-Turner reviewed Sep 18, 2025
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.17.rst
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Outdated
AA-Turner approved these changes Sep 18, 2025
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is significantly better wording, thank you!

A

AlexWaygood enabled auto-merge (squash) September 18, 2025 17:04
AlexWaygood merged commit 4305cc3 into python:main Sep 18, 2025
45 checks passed
AlexWaygood deleted the alex/bad-bytestring branch September 18, 2025 17:30

miss-islington-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
pythongh-118803: Improve documentation around ByteString deprecation (
9835841 
pythonGH-139115)

(cherry picked from commit 4305cc3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

miss-islington-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4305cc3ef35a35f9b2c163ae0ffeea219da5af5d 3.13

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139136 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
hugovk pushed a commit that referenced this pull request Sep 18, 2025
[3.14] gh-118803: Improve documentation around ByteString deprecati…
665a349 
…on (GH-139115) (#139136)

gh-118803: Improve documentation around `ByteString` deprecation (GH-139115)
(cherry picked from commit 4305cc3)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139137 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 18, 2025
AlexWaygood added a commit that referenced this pull request Sep 18, 2025
[3.13] gh-118803: Improve documentation around ByteString deprecati…
8246e25 
…on (#139115) (#139137)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner AA-Turner approved these changes
JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

AlexWaygood

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL