FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-138013: Split TextIO tests from test_io.test_general by cmaloney · Pull Request #139173 · python/cpython · GitHub

/ cpython Public

gh-138013: Split TextIO tests from test_io.test_general - #139173

Merged
vstinner merged 2 commits into
python:mainfrom
cmaloney:split_textio
Sep 30, 2025
ConversationCommits (2)ChecksFiles changed
Merged

gh-138013: Split TextIO tests from test_io.test_general#139173
vstinner merged 2 commits into
python:mainfrom
cmaloney:split_textio

Conversation

cmaloney commented Sep 19, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

These tests take 1.3 seconds on my dev machine, match fairly closely with testing textio.c implementation only.

I'm only planning one more split to these tests after this, finally moving the buffered out of test_general. Timings with -uall,largefile,extralargefile,walltime -M12G

- test_io.test_signals: 24.2 sec
- test_io.test_largefile: 10.0 sec
- test_io.test_general: 8.9 sec
- test_io.test_textio: 1.3 sec
- test_io.test_fileio: 375 ms
- test_io.test_bufferedio: 293 ms
- test_io.test_file: 87 ms
- test_io.test_memoryio: 56 ms
- test_io.test_univnewlines: 31 ms

pythongh-138013: Split TextIO tests from test_general
6704471 
These tests take 1.3 seconds on my dev machine, match fairly closely
with testing `textio.c` implementation only.
bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 19, 2025
bedevere-app Bot mentioned this pull request Sep 19, 2025
Closed
cmaloney changed the title gh-138013: Split TextIO tests from test_general gh-138013: Split TextIO tests from testtest_general Sep 19, 2025
cmaloney changed the title gh-138013: Split TextIO tests from testtest_general gh-138013: Split TextIO tests from test_io.test_general Sep 19, 2025

cmaloney commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

cc: @vstinner (only one more to go after this than test_io split will be done)

vstinner merged commit f752fde into python:main Sep 30, 2025
43 checks passed

vstinner commented Sep 30, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

cmaloney deleted the split_textio branch October 1, 2025 01:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL