gh-139231: Fix estimation of available stack size for recursion limit on macOS - #139232
Merged
markshannon merged 1 commit intoSep 24, 2025
Merged
gh-139231: Fix estimation of available stack size for recursion limit on macOS#139232markshannon merged 1 commit into
markshannon merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… limit on macOS On macOS, use `pthread_get_stackaddr_np()` and `pthread_get_stacksize_np()` to determine the stack address and size (used by code handling the recursion limit), rather than falling back to conservative hard-coded default of 4 MB.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
markshannon
reviewed
Sep 22, 2025
Comment thread
Python/ceval.c
Copy link
Copy Markdown
|
Thanks @rokm for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 24, 2025
… limit on macOS (pythonGH-139232) Use `pthread_get_stackaddr_np()` and `pthread_get_stacksize_np()` to determine the stack address and size. (cherry picked from commit 7016044) Co-authored-by: Rok Mandeljc <rok.mandeljc@gmail.com>
Copy link
Copy Markdown
|
GH-139290 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
zanieb
added a commit
to astral-sh/python-build-standalone
that referenced
this pull request
Oct 15, 2025
encukou
pushed a commit
to encukou/cpython
that referenced
this pull request
Nov 17, 2025
… limit on macOS (pythonGH-139232) Use `pthread_get_stackaddr_np()` and `pthread_get_stacksize_np()` to determine the stack address and size.
hroncok
pushed a commit
to hroncok/cpython
that referenced
this pull request
Nov 24, 2025
… limit on macOS (pythonGH-139232) Use `pthread_get_stackaddr_np()` and `pthread_get_stacksize_np()` to determine the stack address and size. (cherry picked from commit 7016044)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, use pthread_get_stackaddr_np() and pthread_get_stacksize_np() to determine the stack address and size (used by code handling the recursion limit), rather than falling back to conservative hard-coded default of 4 MB.
Fixes #139231; the output of reproducer script is now:
(i.e., stack is fully utilized, as expected).