FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] gh-135374: Adjust test for setuptools' replacement of distutils (GH-138796) by miss-islington · Pull Request #139304 · python/cpython · GitHub

/ cpython Public

[3.9] gh-135374: Adjust test for setuptools' replacement of distutils (GH-138796) - #139304

Merged
ambv merged 2 commits into
python:3.9from
miss-islington:backport-987af36-3.9
Oct 7, 2025
Merged

ambv merged 2 commits into
python:3.9from
miss-islington:backport-987af36-3.9

Conversation

miss-islington commented Sep 24, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

ensurepip installs a bundled copy of distutils, which overrides
the stdlib module. This affects several tests. This commit:

  • skips distutils in test___all__, as we're unlikely to break
    __all__ in a security-fix-only branch (and if we do it's not
    much of a a big deal)
  • skips importability tests of distutils submodules if the
    setuptools hack is detected
    (cherry picked from commit 987af36)

Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Łukasz Langa lukasz@langa.pl
Co-authored-by: Emma Smith emma@emmatyping.dev

…stutils (pythonGH-138796)

ensurepip installs a bundled copy of distutils, which overrides
the stdlib module. This affects several tests. This commit:

- skips distutils in test___all__, as we're unlikely to break
  `__all__` in a security-fix-only branch (and if we do it's not
  much of a a big deal)
- skips importability tests of distutils submodules if the
  setuptools hack is detected
(cherry picked from commit 987af36)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Co-authored-by: Emma Smith <emma@emmatyping.dev>

encukou commented Sep 24, 2025

Copy link
Copy Markdown
Member

!buildbot Installed

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ef179f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139304%2Fmerge

The command will test the builders whose names match following regular expression: Installed

The builders matched are:

  • aarch64 Fedora Rawhide Clang Installed PR
  • x86 Debian Installed with X PR
  • s390x Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Clang Installed PR
  • aarch64 Fedora Stable Clang Installed PR
  • PPC64LE Fedora Rawhide Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Stable Clang Installed PR

encukou self-assigned this Sep 24, 2025

encukou commented Sep 24, 2025

Copy link
Copy Markdown
Member

!buildbot Installed

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit a613979 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139304%2Fmerge

The command will test the builders whose names match following regular expression: Installed

The builders matched are:

  • aarch64 Fedora Rawhide Clang Installed PR
  • x86 Debian Installed with X PR
  • s390x Fedora Stable Clang Installed PR
  • AMD64 Fedora Rawhide Clang Installed PR
  • AMD64 Fedora Stable Clang Installed PR
  • aarch64 Fedora Stable Clang Installed PR
  • PPC64LE Fedora Rawhide Clang Installed PR
  • s390x Fedora Rawhide Clang Installed PR
  • PPC64LE Fedora Stable Clang Installed PR

encukou commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The failure on x86 Debian Installed is pre-existing, and looks unrelated. (I've sometimes managed to reproduce on Fedora, but not consistently; looks like it might involve files left from an earlier install. Would investigate more, but, I'm signing off for the rest of the week.)

encukou requested a review from ambv September 24, 2025 16:15

encukou commented Sep 29, 2025

Copy link
Copy Markdown
Member

The failures on all Installed are all the pre-existing issue, in test_bdb.

ambv merged commit 312de66 into python:3.9 Oct 7, 2025
13 of 19 checks passed
miss-islington deleted the backport-987af36-3.9 branch January 2, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL