FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-90949: amend GH-139234 in prevision of future mitigation API by picnixz · Pull Request #139366 · python/cpython · GitHub

/ cpython Public

gh-90949: amend GH-139234 in prevision of future mitigation API - #139366

Merged
picnixz merged 3 commits into
python:mainfrom
picnixz:feat/xml/post-139234
Sep 26, 2025
ConversationCommits (3)ChecksFiles changed
Merged

gh-90949: amend GH-139234 in prevision of future mitigation API#139366
picnixz merged 3 commits into
python:mainfrom
picnixz:feat/xml/post-139234

Conversation

picnixz commented Sep 26, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

There were some typos that slipped under both @hartwork's and my radar and some functions that could be made more generic and used by the next PR.

📚 Documentation preview 📚: https://cpython-previews--139366.org.readthedocs.build/

picnixz requested a review from AA-Turner as a code owner September 26, 2025 16:22
bedevere-app Bot mentioned this pull request Sep 26, 2025
Closed
This was referenced Sep 26, 2025
Merged
Merged
hartwork approved these changes Sep 26, 2025
View reviewed changes

hartwork left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@picnixz looks alright with me 👍

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
Member Author

Oh thank you for the review. I pinged you on the wrong PR but you saw this one. Thanks!

picnixz enabled auto-merge (squash) September 26, 2025 16:36

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
Member Author

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

picnixz mentioned this pull request Sep 26, 2025
Merged

hartwork commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Once this lands, we can backport this into the backports (just mention that it was also cherry-picked for another commit).

@picnixz sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker. Is that what you meant?

picnixz commented Sep 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

sounds like you have plain git cherry-pick on top the existing branch in mind rather than cherry-picker

yes, I don't know if cherry-picker can do multiple cherry-picks actually

picnixz commented Sep 26, 2025

Copy link
Copy Markdown
Member Author

Mmh, TSAN is taking an incredibly long time.

picnixz merged commit 68a1778 into python:main Sep 26, 2025
81 of 83 checks passed
picnixz deleted the feat/xml/post-139234 branch September 26, 2025 18:16
hartwork pushed a commit to hartwork/cpython that referenced this pull request Sep 26, 2025
pythongh-90949: amend pythonGH-139234 in prevision of future mitigati…
b235056 
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 28, 2025
pythongh-90949: amend pythonGH-139234 in prevision of future mitigati…
b52fc88 
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
pythongh-90949: amend pythonGH-139234 in prevision of future mitigati…
a5d026a 
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 2, 2025
pythongh-90949: amend pythonGH-139234 in prevision of future mitigati…
5680561 
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
hartwork pushed a commit to hartwork/cpython that referenced this pull request Oct 3, 2025
pythongh-90949: amend pythonGH-139234 in prevision of future mitigati…
6ae7665 
…on API (python#139366)

Fix some typos left in f04bea4,
and simplify some internal functions to ease maintenance of future
mitigation APIs.

(cherry picked from commit 68a1778)
hartwork mentioned this pull request Oct 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
1 more reviewer
hartwork hartwork approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL