FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-89973: Fix typo by hartwork · Pull Request #139405 · python/cpython · GitHub

/ cpython Public

gh-89973: Fix typo - #139405

Closed
hartwork wants to merge 1 commit into
python:mainfrom
hartwork:gh-89973-fix-typo
Closed

gh-89973: Fix typo#139405
hartwork wants to merge 1 commit into
python:mainfrom
hartwork:gh-89973-fix-typo

Conversation

hartwork commented Sep 29, 2025
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 29, 2025

picnixz commented Sep 29, 2025

Copy link
Copy Markdown
Member

Ah sorry, I should have explained for typos. In general, we don't fix typos that are not user-facing (that is, we only fix typos in docstrings, docs, error messages, etc, but usually, we don't fix typos in comments; that's to avoid having to backport them and to avoid code churn). If we were to rewrite the fnmatch() tests, then we would fix the typo because it's code that we would touch. Sorry, but this one won't be merged (we don't have an exact policy for typos... it's at the discretion of core devs, and the policy I take is shared by other core devs)

Copy link
Copy Markdown
Contributor Author

@picnixz that's fair, I understand, no worries 👍

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL