gh-138013: Split BufferedIO tests from test_io.test_general - #139454
Merged
vstinner merged 1 commit intoOct 1, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The last remaining set of tests to split out that are focused on one specific implementation portion (`bufferedio.c`). test_io.test_general is now largely tests around `io.open` and module properties (ex. pickling, class hierarchy, module members, etc). This closes python#138013
vstinner
approved these changes
Oct 1, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last remaining set of tests to split out that are focused on one specific implementation portion (bufferedio.c).
test_io.test_general is now just tests around io.open and module properties (ex. pickling, class hierarchy, module members, etc).
cc: @vstinner , This closes #138013