FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

improve isolation of test_pending_call_creates_thread_subinterpreter by kumaraditya303 · Pull Request #139473 · python/cpython · GitHub

/ cpython Public

improve isolation of test_pending_call_creates_thread_subinterpreter - #139473

Closed
kumaraditya303 wants to merge 3 commits into
python:mainfrom
kumaraditya303:better-isolation
Closed

improve isolation of test_pending_call_creates_thread_subinterpreter#139473
kumaraditya303 wants to merge 3 commits into
python:mainfrom
kumaraditya303:better-isolation

Conversation

kumaraditya303 commented Oct 1, 2025
edited
Loading

Copy link
Copy Markdown
Contributor

For better isolation from the current runtime, run the test in a separate subprocess similarly to test_pending_call_creates_thread.

bedevere-app Bot added the tests Tests in the Lib/test dir label Oct 1, 2025
kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0cb09f9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139473%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 1, 2025
kumaraditya303 marked this pull request as ready for review October 1, 2025 11:53

Copy link
Copy Markdown
Member

I'm not sure I understand the rationale here. We already have a test for doing this in a subprocess: test_pending_call_creates_thread.

Copy link
Copy Markdown
Contributor Author

I'm not sure I understand the rationale here. We already have a test for doing this in a subprocess: test_pending_call_creates_thread.

Yes, but that runs in main interpreter but this runs in a sub-interpreter.

Copy link
Copy Markdown
Member

But why do it in a subprocess? We create and destroy subinterpreters in the main process in other tests, don't we?

Copy link
Copy Markdown
Contributor Author

I no longer think this is correct so closed it.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL