gh-138703: clarify data buffer requirement of `asyncio.StreamWriter.write` by kumaraditya303 · Pull Request #139564 · python/cpython · GitHub

Issue: Correctly indicate the input type limitations of asyncio.write and asyncio.sendto #138703

📚 Documentation preview 📚: https://cpython-previews--139564.org.readthedocs.build/

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…iter.write` (pythonGH-139564) (cherry picked from commit 0b21682) Co-authored-by: Kumar Aditya <kumaraditya@python.org>

GH-139570 is a backport of this pull request to the 3.14 branch.

GH-139571 is a backport of this pull request to the 3.13 branch.

…riter.write` (GH-139564) (#139570) Co-authored-by: Kumar Aditya <kumaraditya@python.org>

…riter.write` (GH-139564) (#139571) gh-138703: clarify data buffer requirement of `asyncio.StreamWriter.write` (GH-139564) (cherry picked from commit 0b21682) Co-authored-by: Kumar Aditya <kumaraditya@python.org>

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Refleaks 3.13 (tier-1) has failed when building commit be38883.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1471/builds/1126) and take a look at the build logs.
Check if the failure is related to this commit (be38883) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1471/builds/1126

Failed tests:

test_socket
test_pyrepl

Failed subtests:

test_aead_aes_gcm - test.test_socket.LinuxKernelCryptoAPI.test_aead_aes_gcm
test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/subprocess.py", line 1140, in __del__
    _warn("subprocess %s is still running" % self.pid,
ResourceWarning: subprocess 2734943 is still running
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=7 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/support/__init__.py", line 835, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=7 mode='rb' closefd=True>
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=9 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/support/__init__.py", line 835, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=9 mode='rb' closefd=True>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_socket.py", line 6950, in test_aead_aes_gcm
    op.sendall(plain)
    ~~~~~~~~~~^^^^^^^
OSError: [Errno 22] Invalid argument


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_pyrepl/test_unix_console.py", line 389, in test_repl_eio
    _, err = proc.communicate(timeout=support.SHORT_TIMEOUT)
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/subprocess.py", line 1222, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/subprocess.py", line 2129, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/subprocess.py", line 1269, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '['/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/python', '-E', '-S', '/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.refleak/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 67.5 seconds

…iter.write` (python#139564)

further clarify docs

3568f2a

kumaraditya303 added the topic-asyncio label Oct 4, 2025

kumaraditya303 requested review from 1st1 and asvetlov as code owners October 4, 2025 14:49

kumaraditya303 added the skip news label Oct 4, 2025

kumaraditya303 requested a review from willingc as a code owner October 4, 2025 14:49

kumaraditya303 added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Oct 4, 2025

bedevere-app Bot added the docs Documentation in the Doc dir label Oct 4, 2025

github-project-automation Bot added this to Docs PRs Oct 4, 2025

bedevere-app Bot mentioned this pull request Oct 4, 2025

Correctly indicate the input type limitations of asyncio.write and asyncio.sendto #138703

Closed

bedevere-app Bot added the awaiting core review label Oct 4, 2025

github-project-automation Bot moved this to Todo in Docs PRs Oct 4, 2025

kumaraditya303 linked an issue Oct 4, 2025 that may be closed by this pull request

Correctly indicate the input type limitations of asyncio.write and asyncio.sendto #138703

Closed

AA-Turner reviewed Oct 4, 2025

View reviewed changes

Comment thread Doc/library/asyncio-stream.rst

picnixz reviewed Oct 4, 2025

View reviewed changes

Comment thread Doc/library/asyncio-stream.rst

improve err msg

cac6d40

AA-Turner reviewed Oct 4, 2025

View reviewed changes

Comment thread Lib/asyncio/selector_events.py Outdated

Update Lib/asyncio/selector_events.py

f7b2433

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

kumaraditya303 merged commit 0b21682 into python:main Oct 4, 2025
81 of 83 checks passed

github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 4, 2025

kumaraditya303 deleted the asyncio-docs branch October 4, 2025 16:14

bedevere-app Bot removed the awaiting core review label Oct 4, 2025

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 4, 2025

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 4, 2025

hugovk pushed a commit that referenced this pull request Oct 4, 2025

[3.14] gh-138703 : clarify data buffer requirement of `asyncio.StreamW…

8566ee2

…riter.write` (GH-139564) (#139570) Co-authored-by: Kumar Aditya <kumaraditya@python.org>

danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025

pythongh-138703 : clarify data buffer requirement of `asyncio.StreamWr…

9f73286

…iter.write` (python#139564)

ancieg mentioned this pull request Dec 18, 2025

tests/test_tcp.py::Test_AIO_TCP::test_create_connection_open_con_addr fails on Python 3.13.9 MagicStack/uvloop#701

Closed

gh-138703: clarify data buffer requirement of `asyncio.StreamWriter.write` by kumaraditya303 · Pull Request #139564 · python/cpython · GitHub

Repository navigation

gh-138703: clarify data buffer requirement of asyncio.StreamWriter.write - #139564

gh-138703: clarify data buffer requirement of asyncio.StreamWriter.write#139564
kumaraditya303 merged 3 commits into
python:mainfrom
kumaraditya303:asyncio-docs

kumaraditya303 commented Oct 4, 2025 •
edited by github-actions Bot
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 4, 2025

Uh oh!

bedevere-app Bot commented Oct 4, 2025

Uh oh!

bedevere-app Bot commented Oct 4, 2025

Uh oh!

bedevere-bot commented Oct 4, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-138703: clarify data buffer requirement of `asyncio.StreamWriter.write` by kumaraditya303 · Pull Request #139564 · python/cpython · GitHub

Repository navigation

gh-138703: clarify data buffer requirement of asyncio.StreamWriter.write - #139564

gh-138703: clarify data buffer requirement of asyncio.StreamWriter.write#139564kumaraditya303 merged 3 commits intopython:mainpython/cpython:mainfrom kumaraditya303:asyncio-docskumaraditya303/cpython:asyncio-docsCopy head branch name to clipboard

Conversation

kumaraditya303 commented Oct 4, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 4, 2025

Uh oh!

bedevere-app Bot commented Oct 4, 2025

Uh oh!

bedevere-app Bot commented Oct 4, 2025

Uh oh!

bedevere-bot commented Oct 4, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gh-138703: clarify data buffer requirement of asyncio.StreamWriter.write#139564
kumaraditya303 merged 3 commits into
python:mainfrom
kumaraditya303:asyncio-docs

kumaraditya303 commented Oct 4, 2025 •
edited by github-actions Bot
Loading