FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-96821: Check for `-fstrict-overflow` only if `--with-strict-overflow` is passed by StanFromIreland · Pull Request #139595 · python/cpython · GitHub

/ cpython Public

gh-96821: Check for -fstrict-overflow only if --with-strict-overflow is passed - #139595

Open
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:refactor-autoconf
ConversationCommits (4)ChecksFiles changed
Open

gh-96821: Check for -fstrict-overflow only if --with-strict-overflow is passed#139595
StanFromIreland wants to merge 4 commits into
python:mainfrom
StanFromIreland:refactor-autoconf

Conversation

StanFromIreland commented Oct 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Oct 5, 2025
Open

StanFromIreland commented Nov 8, 2025

Copy link
Copy Markdown
Member Author

Friendly ping @erlend-aasland / @hauntsaninja :-)

erlend-aasland reviewed Mar 8, 2026
View reviewed changes
Comment thread configure.ac Outdated
Comment on lines +2238 to +2246
CFLAGS="-fstrict-overflow -fno-strict-overflow"
AC_CACHE_CHECK([if $CC supports -fstrict-overflow and -fno-strict-overflow],
[ac_cv_cc_supports_fstrict_overflow],
AC_COMPILE_IFELSE(
[AC_LANG_PROGRAM([[]], [[]])],
[ac_cv_cc_supports_fstrict_overflow=yes],
[ac_cv_cc_supports_fstrict_overflow=no]
)
)

erlend-aasland Mar 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should be fine with using AX_CHECK_COMPILE_FLAG here. (I don't remember why I did not recommend that when we added this code.)

StanFromIreland Mar 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are you suggesting we just check -fstrict-overflow? Currently it checks both -fstrict-overflow and -fno-strict-overflow.

StanFromIreland Mar 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Using AX_CHECK_COMPILE_FLAG makes it more complicated to follow IMO, but I pushed the change.

erlend-aasland May 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, I should've been more specific. Currently, we check for the compile flag first, then we check for the configure flag. Now, you've embedded the compile check into the configure flag check. I suggest keeping the original structure. We should be able to use AX_CHECK_COMPILE_FLAG to check for the compile flag(s), and then use those results when we check for the configure flag.

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 30, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 16, 2026

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 Awaiting requested review from corona10 corona10 is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
hauntsaninja Awaiting requested review from hauntsaninja
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

awaiting review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL