FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-133951: Fix purelib packages not found in test_peg_generator TestCParser by Cycloctane · Pull Request #139607 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-133951: Fix purelib packages not found in test_peg_generator TestCParser - #139607

Merged
encukou merged 1 commit into
python:mainfrom
Cycloctane:fix-issue-139604
Oct 6, 2025
ConversationCommits (1)ChecksFiles changed
Merged

gh-133951: Fix purelib packages not found in test_peg_generator TestCParser#139607
encukou merged 1 commit into
python:mainfrom
Cycloctane:fix-issue-139604

Conversation

Cycloctane commented Oct 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Previous import context created in TestCParser.setUpClass() only includes platlib path. This pr also adds purelib path to fix failing test_peg_generator on some platform after #137139 .

bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Oct 5, 2025
bedevere-app Bot mentioned this pull request Oct 5, 2025
Closed

picnixz commented Oct 5, 2025

Copy link
Copy Markdown
Member

!buildbot FIPS only

bedevere-bot commented Oct 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 0aeffb2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139607%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR

picnixz changed the title gh-139604: Fix purelib packages not found in test_peg_generator TestCParser gh-133951: Fix purelib packages not found in test_peg_generator TestCParser Oct 5, 2025
bedevere-app Bot mentioned this pull request Oct 5, 2025
Closed

picnixz commented Oct 5, 2025

Copy link
Copy Markdown
Member

Until the buildbots are done, please don't commit anything.

picnixz mentioned this pull request Oct 5, 2025
Merged

picnixz commented Oct 5, 2025

Copy link
Copy Markdown
Member

The flaky test will be fixed by #139610.

encukou commented Oct 6, 2025

Copy link
Copy Markdown
Member

All green!
Thank you for the fix!

encukou merged commit b73aaff into python:main Oct 6, 2025
85 of 87 checks passed
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
pythongh-133951: Fix purelib packages not found in test_peg_generator…
ae6cfe4 
… TestCParser (pythonGH-139607)

also includes purelib in TestCParser import context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL